about summary refs log tree commit homepage
path: root/lib/PublicInbox/Config.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2022-11-23 04:09:57 +0000
committerEric Wong <e@80x24.org>2022-11-23 10:51:24 +0000
commit99acd1de608f99d90cca15737b71a68f21108d20 (patch)
tree0cbe11a9f3a30d5631234d86a5f1f08dd482d10f /lib/PublicInbox/Config.pm
parent6ca4e03f9a1575c355215f3e49f7abfab70e8329 (diff)
downloadpublic-inbox-99acd1de608f99d90cca15737b71a68f21108d20.tar.gz
We don't want to leak $? from `git config' failures into
lei nor public-inbox-* processes.
Diffstat (limited to 'lib/PublicInbox/Config.pm')
-rw-r--r--lib/PublicInbox/Config.pm5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index c27928de..6a51226e 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -544,11 +544,12 @@ sub urlmatch {
         my $val = <$fh>;
         if (close($fh)) {
                 chomp($val);
-                $val;
         } else {
                 $urlmatch_broken = 1 if (($? >> 8) != 1);
-                undef;
+                undef $val;
         }
+        $? = 0; # don't influence lei exit status
+        $val;
 }
 
 sub json {