about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-03-25 06:20:20 +0200
committerEric Wong <e@80x24.org>2021-03-25 17:58:58 +0000
commita3e3a5f5f34f258744938e60639c0b4d7a362f60 (patch)
treeffacd7557606b2422ad4f7cbfa88a485328d3b33
parent98008cde927c175f77360d2ec5b70dac66931e83 (diff)
downloadpublic-inbox-a3e3a5f5f34f258744938e60639c0b4d7a362f60.tar.gz
There's no need to create or write lei/store when adding
an external, we just need to write to the config file.
-rw-r--r--lib/PublicInbox/LeiExternal.pm2
-rw-r--r--t/lei-externals.t3
2 files changed, 1 insertions, 4 deletions
diff --git a/lib/PublicInbox/LeiExternal.pm b/lib/PublicInbox/LeiExternal.pm
index 56d6ef39..5e8dc71a 100644
--- a/lib/PublicInbox/LeiExternal.pm
+++ b/lib/PublicInbox/LeiExternal.pm
@@ -144,8 +144,6 @@ sub add_external_finish {
 
 sub lei_add_external {
         my ($self, $location) = @_;
-        my $sto = $self->_lei_store(1);
-        $sto->write_prepare($self);
         my $opt = $self->{opt};
         my $mirror = $opt->{mirror} // do {
                 my @fail;
diff --git a/t/lei-externals.t b/t/lei-externals.t
index 2045691f..afd90d19 100644
--- a/t/lei-externals.t
+++ b/t/lei-externals.t
@@ -93,8 +93,7 @@ test_lei(sub {
                                 \'added external');
                 is($lei_out.$lei_err, '', 'no output');
         });
-        ok(-s $config_file && -e $store_dir,
-                'add-external created config + store');
+        ok(-s $config_file, 'add-external created config');
         my $lcfg = PublicInbox::Config->new($config_file);
         $cfg->each_inbox(sub {
                 my ($ibx) = @_;