about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-03-24 14:23:34 +0500
committerEric Wong <e@80x24.org>2021-03-24 23:01:21 +0000
commit636604567b8ff6118c5fcf25e2912a50e0050ca2 (patch)
tree18591aa21ad4534b56216e12ac72e67fab5a2044
parent59bb5f9287d5cd8009d8aae2d07fbf47d1b6bd91 (diff)
downloadpublic-inbox-636604567b8ff6118c5fcf25e2912a50e0050ca2.tar.gz
All of our $lei->workers_start callers can simply rely on
that wrapper to do the right thing and pass fields to
->wq_worker_start children, only.

This could manifest as a unbound memory growth if somebody is
constantly mirroring, and was causing tests to get stuck when
experimenting with a persistent lei-daemon for the entire
test suite.
-rw-r--r--lib/PublicInbox/LeiMirror.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm
index 6e62625d..d68cd6c1 100644
--- a/lib/PublicInbox/LeiMirror.pm
+++ b/lib/PublicInbox/LeiMirror.pm
@@ -268,7 +268,7 @@ sub do_mirror { # via wq_io_do
 
 sub start {
         my ($cls, $lei, $src, $dst) = @_;
-        my $self = bless { lei => $lei, src => $src, dst => $dst }, $cls;
+        my $self = bless { src => $src, dst => $dst }, $cls;
         if ($src =~ m!https?://!) {
                 require URI;
                 require PublicInbox::LeiCurl;