diff options
| author | Eric Wong <e@80x24.org> | 2022-12-21 23:22:10 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2022-12-21 23:28:19 +0000 |
| commit | 56e6e587745ca2aa04c17352d8662098b68c596f (patch) | |
| tree | ba3ee50644f680f8ac792d9c42fac16a965bb28f | |
| parent | e683fa9ea41f44191e32be6af37069210c4593e2 (diff) | |
| download | public-inbox-56e6e587745ca2aa04c17352d8662098b68c596f.tar.gz | |
This ensures we get consistent pipelining behavior across platforms. Furthermore, a smaller value is probably more reasonable since "git cat-file" can usually outpace indexing and lower values allow us to react to user interaction (e.g. Ctrl-C) more quickly. The previous value based on Linux PIPE_BUF (4096) allowed a value of 189 which worked fine on non-musl Linux systems, but failed on musl-based Void and Alpine Linux. Mysteriously, this works on musl up to a value of 114 and starts locking up at 115. The reason for this failure is currently unexplained and will hopefully be discovered soon. Regardless, capping the value to 23 based on the universal PIPE_BUF minimum (512) seems reasonable, anyways. Reported-by: Chris Brannon <chris@the-brannons.com> Tested-by: Chris Brannon <chris@the-brannons.com> Link: https://public-inbox.org/meta/87edssl7u0.fsf@the-brannons.com/T/
| -rw-r--r-- | lib/PublicInbox/Git.pm | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index 882a9a4a..a1af776b 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -28,8 +28,10 @@ our $in_cleanup; our $RDTIMEO = 60_000; # milliseconds our $async_warn; # true in read-only daemons -use constant MAX_INFLIGHT => (POSIX::PIPE_BUF * 3) / - 65; # SHA-256 hex size + "\n" in preparation for git using non-SHA1 +# 512: POSIX PIPE_BUF minimum (see pipe(7)) +# 3: @$inflight is flattened [ $OID, $cb, $arg ] +# 65: SHA-256 hex size + "\n" in preparation for git using non-SHA1 +use constant MAX_INFLIGHT => 512 * 3 / 65; my %GIT_ESC = ( a => "\a", |