about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-07-07 20:37:37 +0000
committerEric Wong <e@yhbt.net>2020-07-10 11:27:08 +0000
commit42a6fc1794099cb2585d3c290e42a20d5ef56b89 (patch)
treef68ac0dac92a78d8cc21ee5e22ed3d387f82ed9e
parent1bfff88a34210d5e944424c3a96e4d60979ace4d (diff)
downloadpublic-inbox-42a6fc1794099cb2585d3c290e42a20d5ef56b89.tar.gz
Non-slice mailboxes never have messages themselves,
so we must not assume a message exists when sending
untagged EXISTS messages.
-rw-r--r--lib/PublicInbox/IMAP.pm1
-rw-r--r--t/imapd.t4
2 files changed, 5 insertions, 0 deletions
diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index d8c898f4..8ab4b1e7 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -246,6 +246,7 @@ sub uo2m_extend ($$;$) {
         my $base = $self->{uid_base};
         ++$beg;
         my $uids = $self->{ibx}->over->uid_range($beg, $base + UID_SLICE);
+        return $uo2m if !scalar(@$uids);
         my @tmp; # [$UID_OFFSET] => $MSN
         my $write_method = $_[2] // 'msg_more';
         if (ref($uo2m)) {
diff --git a/t/imapd.t b/t/imapd.t
index 1ac6a4ab..6cfced41 100644
--- a/t/imapd.t
+++ b/t/imapd.t
@@ -87,12 +87,16 @@ my $post_auth_anon_capa = $mic->capability;
 is_deeply($post_auth_anon_capa, $post_login_capa,
         'auth anon has same capabilities');
 my $e;
+ok($mic->noop, 'NOOP');
+ok($mic->noop, 'NOOP (again)'); # for warnings
 ok(!$mic->examine('foo') && ($e = $@), 'EXAMINE non-existent');
 like($e, qr/\bNO\b/, 'got a NO on EXAMINE for non-existent');
 ok(!$mic->select('foo') && ($e = $@), 'EXAMINE non-existent');
 like($e, qr/\bNO\b/, 'got a NO on EXAMINE for non-existent');
 my $mailbox1 = "inbox.i1.$first_range";
 ok($mic->select('inbox.i1'), 'SELECT on parent succeeds');
+ok($mic->noop, 'NOOP while selected');
+ok($mic->noop, 'NOOP again while selected'); # check warnings later
 ok($mic->select($mailbox1), 'SELECT succeeds');
 ok($mic->examine($mailbox1), 'EXAMINE succeeds');
 my @raw = $mic->status($mailbox1, qw(Messages uidnext uidvalidity));