about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-06-10 07:04:43 +0000
committerEric Wong <e@yhbt.net>2020-06-13 07:55:45 +0000
commit3be137e00841a1b888e9b6bbbd371a040c865bab (patch)
tree253dd7999dfc87871343c82691ae14c344574dff
parentd67fff9abf168c7517311bdd8987ce174a60f2c4 (diff)
downloadpublic-inbox-3be137e00841a1b888e9b6bbbd371a040c865bab.tar.gz
We'll use the xqx() to avoid losing too much performance
compared to normal `backtick` (qx) when testing using
"make check-run" + Inline::C.
-rw-r--r--t/config.t15
1 files changed, 6 insertions, 9 deletions
diff --git a/t/config.t b/t/config.t
index 1f50bb86..3f41c004 100644
--- a/t/config.t
+++ b/t/config.t
@@ -209,20 +209,17 @@ EOF
 }
 
 {
-        my $check_git = !!$ENV{CHECK_GIT_BOOL};
         for my $t (qw(TRUE true yes on 1 +1 -1 13 0x1 0x12 0X5)) {
                 is(PublicInbox::Config::_git_config_bool($t), 1, "$t is true");
-                if ($check_git) {
-                        is(`git -c test.val=$t config --bool test.val`,
-                                "true\n", "$t matches git-config behavior");
-                }
+                is(xqx([qw(git -c), "test.val=$t",
+                        qw(config --bool test.val)]),
+                        "true\n", "$t matches git-config behavior");
         }
         for my $f (qw(FALSE false no off 0 +0 +000 00 0x00 0X0)) {
                 is(PublicInbox::Config::_git_config_bool($f), 0, "$f is false");
-                if ($check_git) {
-                        is(`git -c test.val=$f config --bool test.val`,
-                                "false\n", "$f matches git-config behavior");
-                }
+                is(xqx([qw(git -c), "test.val=$f",
+                        qw(config --bool test.val)]),
+                        "false\n", "$f matches git-config behavior");
         }
         is(PublicInbox::Config::_git_config_bool('bogus'), undef,
                 'bogus is undef');