* [PATCH 2/3] xt/solver: skip on missing publicinbox.git.coderepo
2022-10-10 21:34 5% [PATCH 0/3] www: viewvcs: tags + minor updates Eric Wong
@ 2022-10-10 21:34 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-10-10 21:34 UTC (permalink / raw)
To: meta
Solver tests can never succeed without coderepos configured,
since that's the whole point of solver. And improve the
original skip message to note that it's about the `git'
public-inbox, not `git' itself.
---
xt/solver.t | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/xt/solver.t b/xt/solver.t
index c76e0b0a..cd894edd 100644
--- a/xt/solver.t
+++ b/xt/solver.t
@@ -48,9 +48,16 @@ my $client = sub {
my $nr = 0;
while (($ibx_name, $urls) = each %$todo) {
SKIP: {
- if (!$cfg->lookup_name($ibx_name)) {
+ my $ibx = $cfg->lookup_name($ibx_name);
+ if (!$ibx) {
push @gone, $ibx_name;
- skip("$ibx_name not configured", scalar(@$urls));
+ skip(qq{[publicinbox "$ibx_name"] not configured},
+ scalar(@$urls));
+ }
+ if (!defined($ibx->{coderepo})) {
+ push @gone, $ibx_name;
+ skip(qq{publicinbox.$ibx_name.coderepo not configured},
+ scalar(@$urls));
}
test_psgi($app, $client);
$nr++;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] www: viewvcs: tags + minor updates
@ 2022-10-10 21:34 5% Eric Wong
2022-10-10 21:34 7% ` [PATCH 2/3] xt/solver: skip on missing publicinbox.git.coderepo Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-10-10 21:34 UTC (permalink / raw)
To: meta
I noticed the /$CODEREPO/ summary endpoint links to tags,
so we'll support handling annotated tags via /($CODEREPO|$INBOX)/$OID/s/,
now. Still not sure how to best deal with multiple search endpoints,
yet...
Eric Wong (3):
viewvcs: avoid one ascii_html call
xt/solver: skip on missing publicinbox.git.coderepo
www: viewvcs: display annotated tags as discreet objects
lib/PublicInbox/ViewVCS.pm | 51 +++++++++++++++++++++++++++++++++++---
xt/solver.t | 12 +++++++--
2 files changed, 57 insertions(+), 6 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-10-10 21:34 5% [PATCH 0/3] www: viewvcs: tags + minor updates Eric Wong
2022-10-10 21:34 7% ` [PATCH 2/3] xt/solver: skip on missing publicinbox.git.coderepo Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).