From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C54A31F51E for ; Mon, 10 Oct 2022 21:34:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1665437662; bh=0LC+VrWY3uUC6jZ7MGYxM8F1hDeRj6YP+ZKF5u1dozA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=mBegEfpDLfl3yREj/zBDMupBhhTslE1Cid8MBvkFcglZFcCYsv0MPaYk7MqidikDH rgF9mraxnYKx76OTGNzVmlFdkrDl4Gy8V6Llbd1p2AcK+7RJSOX/JjcHgQrrb+RTra F9ll06lpU0ioUjjU86VE+nV18y11z/8z16lO84aY= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/3] xt/solver: skip on missing publicinbox.git.coderepo Date: Mon, 10 Oct 2022 21:34:21 +0000 Message-Id: <20221010213422.23048-3-e@80x24.org> In-Reply-To: <20221010213422.23048-1-e@80x24.org> References: <20221010213422.23048-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Solver tests can never succeed without coderepos configured, since that's the whole point of solver. And improve the original skip message to note that it's about the `git' public-inbox, not `git' itself. --- xt/solver.t | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/xt/solver.t b/xt/solver.t index c76e0b0a..cd894edd 100644 --- a/xt/solver.t +++ b/xt/solver.t @@ -48,9 +48,16 @@ my $client = sub { my $nr = 0; while (($ibx_name, $urls) = each %$todo) { SKIP: { - if (!$cfg->lookup_name($ibx_name)) { + my $ibx = $cfg->lookup_name($ibx_name); + if (!$ibx) { push @gone, $ibx_name; - skip("$ibx_name not configured", scalar(@$urls)); + skip(qq{[publicinbox "$ibx_name"] not configured}, + scalar(@$urls)); + } + if (!defined($ibx->{coderepo})) { + push @gone, $ibx_name; + skip(qq{publicinbox.$ibx_name.coderepo not configured}, + scalar(@$urls)); } test_psgi($app, $client); $nr++;