From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] xt/solver: skip on missing publicinbox.git.coderepo
Date: Mon, 10 Oct 2022 21:34:21 +0000 [thread overview]
Message-ID: <20221010213422.23048-3-e@80x24.org> (raw)
In-Reply-To: <20221010213422.23048-1-e@80x24.org>
Solver tests can never succeed without coderepos configured,
since that's the whole point of solver. And improve the
original skip message to note that it's about the `git'
public-inbox, not `git' itself.
---
xt/solver.t | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/xt/solver.t b/xt/solver.t
index c76e0b0a..cd894edd 100644
--- a/xt/solver.t
+++ b/xt/solver.t
@@ -48,9 +48,16 @@ my $client = sub {
my $nr = 0;
while (($ibx_name, $urls) = each %$todo) {
SKIP: {
- if (!$cfg->lookup_name($ibx_name)) {
+ my $ibx = $cfg->lookup_name($ibx_name);
+ if (!$ibx) {
push @gone, $ibx_name;
- skip("$ibx_name not configured", scalar(@$urls));
+ skip(qq{[publicinbox "$ibx_name"] not configured},
+ scalar(@$urls));
+ }
+ if (!defined($ibx->{coderepo})) {
+ push @gone, $ibx_name;
+ skip(qq{publicinbox.$ibx_name.coderepo not configured},
+ scalar(@$urls));
}
test_psgi($app, $client);
$nr++;
next prev parent reply other threads:[~2022-10-10 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 21:34 [PATCH 0/3] www: viewvcs: tags + minor updates Eric Wong
2022-10-10 21:34 ` [PATCH 1/3] viewvcs: avoid one ascii_html call Eric Wong
2022-10-10 21:34 ` Eric Wong [this message]
2022-10-10 21:34 ` [PATCH 3/3] www: viewvcs: display annotated tags as discreet objects Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010213422.23048-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).