* [PATCH] usercontent: stop relying on autodie
@ 2019-05-22 7:29 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2019-05-22 7:29 UTC (permalink / raw)
To: meta
It's a non-standard package on CentOS-7, actually; and we
shouldn't bloat the PSGI server by loading a module which
isn't strictly needed.
---
lib/PublicInbox/UserContent.pm | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/UserContent.pm b/lib/PublicInbox/UserContent.pm
index 2a25816..f01160d 100644
--- a/lib/PublicInbox/UserContent.pm
+++ b/lib/PublicInbox/UserContent.pm
@@ -88,9 +88,8 @@ sub sample ($$) {
# usage: perl -I lib __FILE__ contrib/css/216dark.css
# (See Makefile.PL)
if (scalar(@ARGV) == 1 && -r __FILE__) {
- use autodie;
- open my $ro, '<', $ARGV[0];
- my $css = do { local $/; <$ro> };
+ open my $ro, '<', $ARGV[0] or die $!;
+ my $css = do { local $/; <$ro> } or die $!;
# indent one level:
$css =~ s/^([ \t]*\S)/\t$1/smg;
@@ -99,11 +98,12 @@ if (scalar(@ARGV) == 1 && -r __FILE__) {
$css =~ s/;/ !important;/sg;
$css =~ s/(\w) \}/$1 !important }/msg;
- open my $rw, '+<', __FILE__;
- my $out = do { local $/; <$rw> };
+ open my $rw, '+<', __FILE__ or die $!;
+ my $out = do { local $/; <$rw> } or die $!;
$out =~ s/^sub CSS.*^_\n\}/sub CSS () {\n\t<<'_'\n${css}_\n}/sm;
seek $rw, 0, 0;
- print $rw $out;
+ print $rw $out or die $!;
+ close $rw or die $!;
}
1;
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-05-22 7:29 7% [PATCH] usercontent: stop relying on autodie Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).