From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 5F97C1F462 for ; Wed, 22 May 2019 07:29:25 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] usercontent: stop relying on autodie Date: Wed, 22 May 2019 07:29:25 +0000 Message-Id: <20190522072925.536-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It's a non-standard package on CentOS-7, actually; and we shouldn't bloat the PSGI server by loading a module which isn't strictly needed. --- lib/PublicInbox/UserContent.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/UserContent.pm b/lib/PublicInbox/UserContent.pm index 2a25816..f01160d 100644 --- a/lib/PublicInbox/UserContent.pm +++ b/lib/PublicInbox/UserContent.pm @@ -88,9 +88,8 @@ sub sample ($$) { # usage: perl -I lib __FILE__ contrib/css/216dark.css # (See Makefile.PL) if (scalar(@ARGV) == 1 && -r __FILE__) { - use autodie; - open my $ro, '<', $ARGV[0]; - my $css = do { local $/; <$ro> }; + open my $ro, '<', $ARGV[0] or die $!; + my $css = do { local $/; <$ro> } or die $!; # indent one level: $css =~ s/^([ \t]*\S)/\t$1/smg; @@ -99,11 +98,12 @@ if (scalar(@ARGV) == 1 && -r __FILE__) { $css =~ s/;/ !important;/sg; $css =~ s/(\w) \}/$1 !important }/msg; - open my $rw, '+<', __FILE__; - my $out = do { local $/; <$rw> }; + open my $rw, '+<', __FILE__ or die $!; + my $out = do { local $/; <$rw> } or die $!; $out =~ s/^sub CSS.*^_\n\}/sub CSS () {\n\t<<'_'\n${css}_\n}/sm; seek $rw, 0, 0; - print $rw $out; + print $rw $out or die $!; + close $rw or die $!; } 1; -- EW