user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] usercontent: stop relying on autodie
Date: Wed, 22 May 2019 07:29:25 +0000	[thread overview]
Message-ID: <20190522072925.536-1-e@80x24.org> (raw)

It's a non-standard package on CentOS-7, actually; and we
shouldn't bloat the PSGI server by loading a module which
isn't strictly needed.
---
 lib/PublicInbox/UserContent.pm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/PublicInbox/UserContent.pm b/lib/PublicInbox/UserContent.pm
index 2a25816..f01160d 100644
--- a/lib/PublicInbox/UserContent.pm
+++ b/lib/PublicInbox/UserContent.pm
@@ -88,9 +88,8 @@ sub sample ($$) {
 # usage: perl -I lib __FILE__ contrib/css/216dark.css
 # (See Makefile.PL)
 if (scalar(@ARGV) == 1 && -r __FILE__) {
-	use autodie;
-	open my $ro, '<', $ARGV[0];
-	my $css = do { local $/; <$ro> };
+	open my $ro, '<', $ARGV[0] or die $!;
+	my $css = do { local $/; <$ro> } or die $!;
 
 	# indent one level:
 	$css =~ s/^([ \t]*\S)/\t$1/smg;
@@ -99,11 +98,12 @@ if (scalar(@ARGV) == 1 && -r __FILE__) {
 	$css =~ s/;/ !important;/sg;
 	$css =~ s/(\w) \}/$1 !important }/msg;
 
-	open my $rw, '+<', __FILE__;
-	my $out = do { local $/; <$rw> };
+	open my $rw, '+<', __FILE__ or die $!;
+	my $out = do { local $/; <$rw> } or die $!;
 	$out =~ s/^sub CSS.*^_\n\}/sub CSS () {\n\t<<'_'\n${css}_\n}/sm;
 	seek $rw, 0, 0;
-	print $rw $out;
+	print $rw $out or die $!;
+	close $rw or die $!;
 }
 
 1;
-- 
EW


                 reply	other threads:[~2019-05-22  7:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522072925.536-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).