* [PATCH 01/11] qspawn: drop lineno from command failure warning
2023-01-24 9:49 6% [PATCH 00/11] www_coderepo: subjective web stuffs Eric Wong
@ 2023-01-24 9:49 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-01-24 9:49 UTC (permalink / raw)
To: meta
git, cgit, or any other command failing isn't an error
we can do anything about in qspawn, so don't have Perl
emit line number info and needlessly pollute logs.
---
lib/PublicInbox/Qspawn.pm | 2 +-
t/solver_git.t | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index cc81a4cd..5e4fd5cb 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -85,7 +85,7 @@ sub finalize ($) {
if (my $dst = $self->{qsp_err}) {
$$dst .= $$dst ? " $err" : "; $err";
}
- warn "@{$self->{cmd}}: $err" if !$self->{-quiet};
+ warn "@{$self->{cmd}}: $err\n" if !$self->{-quiet};
}
my ($env, $qx_cb, $qx_arg, $qx_buf) =
diff --git a/t/solver_git.t b/t/solver_git.t
index 06d75816..122cf888 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -336,7 +336,7 @@ EOF
open $fh, '>', "$tmpdir/stderr.log" or xbail $!;
ok($s =~ s/^fatal: your current branch.*?\n//sm,
'got current branch warning');
- ok($s =~ s/^.*? exit status=[1-9]+ .*?\n//sm,
+ ok($s =~ s/^.*? exit status=[1-9]+\n\z//sm,
'got exit status warning');
is($s, '', 'no unexpected warnings on empty coderepo');
}
^ permalink raw reply related [relevance 7%]
* [PATCH 00/11] www_coderepo: subjective web stuffs
@ 2023-01-24 9:49 6% Eric Wong
2023-01-24 9:49 7% ` [PATCH 01/11] qspawn: drop lineno from command failure warning Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-01-24 9:49 UTC (permalink / raw)
To: meta
Aside from avoiding FD waste for /dev/null in common
deployments, there's not much _measurably_ better.
Eric Wong (11):
qspawn: drop lineno from command failure warning
viewvcs: add path name hint based on `b=' query param
viewvcs: prepopulate search bar with dfpost + dfn
www_coderepo: show /$INBOX/?t=$DATE link for commits
www_coderepo: eliminate debug log footer
http: reuse STDIN if it's already /dev/null
viewvcs: expand on path names being "non-authoritative"
viewvcs: show message for 404||500 errors
solver_git: remove extraneous leading `-'
www_coderepo: remove some needless return statements
viewvcs: improve tree glossary view
lib/PublicInbox/HTTP.pm | 8 ++++-
lib/PublicInbox/Qspawn.pm | 2 +-
lib/PublicInbox/RepoTree.pm | 3 +-
lib/PublicInbox/SolverGit.pm | 2 +-
lib/PublicInbox/ViewVCS.pm | 56 ++++++++++++++++++++++++++--------
lib/PublicInbox/WwwCoderepo.pm | 50 +++++++++++++++---------------
t/solver_git.t | 2 +-
7 files changed, 81 insertions(+), 42 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-01-24 9:49 6% [PATCH 00/11] www_coderepo: subjective web stuffs Eric Wong
2023-01-24 9:49 7% ` [PATCH 01/11] qspawn: drop lineno from command failure warning Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).