user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 01/11] qspawn: drop lineno from command failure warning
Date: Tue, 24 Jan 2023 09:49:30 +0000	[thread overview]
Message-ID: <20230124094940.572017-2-e@80x24.org> (raw)
In-Reply-To: <20230124094940.572017-1-e@80x24.org>

git, cgit, or any other command failing isn't an error
we can do anything about in qspawn, so don't have Perl
emit line number info and needlessly pollute logs.
---
 lib/PublicInbox/Qspawn.pm | 2 +-
 t/solver_git.t            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index cc81a4cd..5e4fd5cb 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -85,7 +85,7 @@ sub finalize ($) {
 		if (my $dst = $self->{qsp_err}) {
 			$$dst .= $$dst ? " $err" : "; $err";
 		}
-		warn "@{$self->{cmd}}: $err" if !$self->{-quiet};
+		warn "@{$self->{cmd}}: $err\n" if !$self->{-quiet};
 	}
 
 	my ($env, $qx_cb, $qx_arg, $qx_buf) =
diff --git a/t/solver_git.t b/t/solver_git.t
index 06d75816..122cf888 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -336,7 +336,7 @@ EOF
 			open $fh, '>', "$tmpdir/stderr.log" or xbail $!;
 			ok($s =~ s/^fatal: your current branch.*?\n//sm,
 				'got current branch warning');
-			ok($s =~ s/^.*? exit status=[1-9]+ .*?\n//sm,
+			ok($s =~ s/^.*? exit status=[1-9]+\n\z//sm,
 				'got exit status warning');
 			is($s, '', 'no unexpected warnings on empty coderepo');
 		}

  reply	other threads:[~2023-01-24  9:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24  9:49 [PATCH 00/11] www_coderepo: subjective web stuffs Eric Wong
2023-01-24  9:49 ` Eric Wong [this message]
2023-01-24  9:49 ` [PATCH 02/11] viewvcs: add path name hint based on `b=' query param Eric Wong
2023-01-24  9:49 ` [PATCH 03/11] viewvcs: prepopulate search bar with dfpost + dfn Eric Wong
2023-01-24  9:49 ` [PATCH 04/11] www_coderepo: show /$INBOX/?t=$DATE link for commits Eric Wong
2023-01-24  9:49 ` [PATCH 05/11] www_coderepo: eliminate debug log footer Eric Wong
2023-01-24  9:49 ` [PATCH 06/11] http: reuse STDIN if it's already /dev/null Eric Wong
2023-01-24  9:49 ` [PATCH 07/11] viewvcs: expand on path names being "non-authoritative" Eric Wong
2023-01-24  9:49 ` [PATCH 08/11] viewvcs: show message for 404||500 errors Eric Wong
2023-01-24  9:49 ` [PATCH 09/11] solver_git: remove extraneous leading `-' Eric Wong
2023-01-24  9:49 ` [PATCH 10/11] www_coderepo: remove some needless return statements Eric Wong
2023-01-24  9:49 ` [PATCH 11/11] viewvcs: improve tree glossary view Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230124094940.572017-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).