From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 4B8A01F59D for ; Tue, 24 Jan 2023 09:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1674553804; bh=9gUxfkUBLKHvjJnU7QK2MR+ngj1X5zk/6znZO+y8UUo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=a/aX612zB7d7VME53/NsqXseh/h66RBZI8QlP2KWLm03V3RRf6prBuO7AyWPRt+x0 uxiQgZIrVacuSFaDf1PmI3A9hHp3iLFOLH8urrF/2Q40gP6l8bF/SAgasEBQKr9XV+ HzhRm8ar2SRNKDyZokHxktLwM3kE/OYA5Ni2VBh8= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 01/11] qspawn: drop lineno from command failure warning Date: Tue, 24 Jan 2023 09:49:30 +0000 Message-Id: <20230124094940.572017-2-e@80x24.org> In-Reply-To: <20230124094940.572017-1-e@80x24.org> References: <20230124094940.572017-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: git, cgit, or any other command failing isn't an error we can do anything about in qspawn, so don't have Perl emit line number info and needlessly pollute logs. --- lib/PublicInbox/Qspawn.pm | 2 +- t/solver_git.t | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm index cc81a4cd..5e4fd5cb 100644 --- a/lib/PublicInbox/Qspawn.pm +++ b/lib/PublicInbox/Qspawn.pm @@ -85,7 +85,7 @@ sub finalize ($) { if (my $dst = $self->{qsp_err}) { $$dst .= $$dst ? " $err" : "; $err"; } - warn "@{$self->{cmd}}: $err" if !$self->{-quiet}; + warn "@{$self->{cmd}}: $err\n" if !$self->{-quiet}; } my ($env, $qx_cb, $qx_arg, $qx_buf) = diff --git a/t/solver_git.t b/t/solver_git.t index 06d75816..122cf888 100644 --- a/t/solver_git.t +++ b/t/solver_git.t @@ -336,7 +336,7 @@ EOF open $fh, '>', "$tmpdir/stderr.log" or xbail $!; ok($s =~ s/^fatal: your current branch.*?\n//sm, 'got current branch warning'); - ok($s =~ s/^.*? exit status=[1-9]+ .*?\n//sm, + ok($s =~ s/^.*? exit status=[1-9]+\n\z//sm, 'got exit status warning'); is($s, '', 'no unexpected warnings on empty coderepo'); }