* [PATCH 3/3] lei_to_mail: show supported mbox formats on error
2024-01-10 11:18 5% [PATCH 0/3] lei NNTP + error handling fixes Eric Wong
@ 2024-01-10 11:18 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2024-01-10 11:18 UTC (permalink / raw)
To: meta
Users may accidentally or unknowingly write `mbox' and not know
we support 4 incompatible mbox variants.
---
lib/PublicInbox/LeiToMail.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/LeiToMail.pm b/lib/PublicInbox/LeiToMail.pm
index de75e99e..008da52e 100644
--- a/lib/PublicInbox/LeiToMail.pm
+++ b/lib/PublicInbox/LeiToMail.pm
@@ -407,7 +407,9 @@ sub new {
$lei->{opt}->{save} //= \1 if $lei->{cmd} eq 'q';
} elsif (substr($fmt, 0, 4) eq 'mbox') {
require PublicInbox::MboxReader;
- $self->can("eml2$fmt") or die "bad mbox format: $fmt\n";
+ $self->can("eml2$fmt") or die <<EOM;
+E: bad mbox format: $fmt (did you mean: mboxrd, mboxo, mboxcl, or mboxcl2?)
+EOM
$self->{base_type} = 'mbox';
if ($lei->{cmd} eq 'q' &&
(($lei->path_to_fd($dst) // -1) < 0) &&
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] lei NNTP + error handling fixes
@ 2024-01-10 11:18 5% Eric Wong
2024-01-10 11:18 7% ` [PATCH 3/3] lei_to_mail: show supported mbox formats on error Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2024-01-10 11:18 UTC (permalink / raw)
To: meta
These apply to public-inbox-watch, too, actually. I also
just noticed 3/3 while testing something after 2/3.
Eric Wong (3):
net_reader: fix NNTP credential use
lei+net_reader: show NNTP message in more failures
lei_to_mail: show supported mbox formats on error
lib/PublicInbox/LeiLsMailSource.pm | 6 +++++-
lib/PublicInbox/LeiToMail.pm | 4 +++-
lib/PublicInbox/NetReader.pm | 24 +++++++++++++++---------
3 files changed, 23 insertions(+), 11 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2024-01-10 11:18 5% [PATCH 0/3] lei NNTP + error handling fixes Eric Wong
2024-01-10 11:18 7% ` [PATCH 3/3] lei_to_mail: show supported mbox formats on error Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).