From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 5541F1F51A for ; Wed, 10 Jan 2024 11:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1704885536; bh=ztpYv2bjXGc3kjI+taMLlzPKnGvIvAKgGm6+sVBGmQ4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=YLIsHeNiUMrI+r7meavmzx2g1pJDrZG39CONcG+vPPuRqNBzxLJ7yctmOJ4V5qjxM MfSqzzoSSVnn+KtNvgSCGtjGzgiiSaVMrOMC/IAn6Q0lUTnMGMFnUSLeo8QSiwu1Gk ZSC/qUeYd5rM+qvs39sr+QjDyKCkcUZTaKHWXjR0= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/3] lei_to_mail: show supported mbox formats on error Date: Wed, 10 Jan 2024 11:18:55 +0000 Message-ID: <20240110111855.2656443-4-e@80x24.org> In-Reply-To: <20240110111855.2656443-1-e@80x24.org> References: <20240110111855.2656443-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Users may accidentally or unknowingly write `mbox' and not know we support 4 incompatible mbox variants. --- lib/PublicInbox/LeiToMail.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/LeiToMail.pm b/lib/PublicInbox/LeiToMail.pm index de75e99e..008da52e 100644 --- a/lib/PublicInbox/LeiToMail.pm +++ b/lib/PublicInbox/LeiToMail.pm @@ -407,7 +407,9 @@ sub new { $lei->{opt}->{save} //= \1 if $lei->{cmd} eq 'q'; } elsif (substr($fmt, 0, 4) eq 'mbox') { require PublicInbox::MboxReader; - $self->can("eml2$fmt") or die "bad mbox format: $fmt\n"; + $self->can("eml2$fmt") or die <{base_type} = 'mbox'; if ($lei->{cmd} eq 'q' && (($lei->path_to_fd($dst) // -1) < 0) &&