user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/3] lei_to_mail: show supported mbox formats on error
Date: Wed, 10 Jan 2024 11:18:55 +0000	[thread overview]
Message-ID: <20240110111855.2656443-4-e@80x24.org> (raw)
In-Reply-To: <20240110111855.2656443-1-e@80x24.org>

Users may accidentally or unknowingly write `mbox' and not know
we support 4 incompatible mbox variants.
---
 lib/PublicInbox/LeiToMail.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/LeiToMail.pm b/lib/PublicInbox/LeiToMail.pm
index de75e99e..008da52e 100644
--- a/lib/PublicInbox/LeiToMail.pm
+++ b/lib/PublicInbox/LeiToMail.pm
@@ -407,7 +407,9 @@ sub new {
 		$lei->{opt}->{save} //= \1 if $lei->{cmd} eq 'q';
 	} elsif (substr($fmt, 0, 4) eq 'mbox') {
 		require PublicInbox::MboxReader;
-		$self->can("eml2$fmt") or die "bad mbox format: $fmt\n";
+		$self->can("eml2$fmt") or die <<EOM;
+E: bad mbox format: $fmt (did you mean: mboxrd, mboxo, mboxcl, or mboxcl2?)
+EOM
 		$self->{base_type} = 'mbox';
 		if ($lei->{cmd} eq 'q' &&
 				(($lei->path_to_fd($dst) // -1) < 0) &&

      parent reply	other threads:[~2024-01-10 11:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 11:18 [PATCH 0/3] lei NNTP + error handling fixes Eric Wong
2024-01-10 11:18 ` [PATCH 1/3] net_reader: fix NNTP credential use Eric Wong
2024-01-10 11:18 ` [PATCH 2/3] lei+net_reader: show NNTP message in more failures Eric Wong
2024-01-10 11:18 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110111855.2656443-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).