* [PATCH 7/7] import: (cleanup) drop redundant env arg to run_die
2019-11-29 10:14 6% [PATCH 0/7] some low impact changes and cleanups Eric Wong
@ 2019-11-29 10:14 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-11-29 10:14 UTC (permalink / raw)
To: meta
run_die() doesn't require an $env arg, so there's no
point passing "undef" to it.
---
lib/PublicInbox/Import.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 8a369ee4..46de09c4 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -178,14 +178,14 @@ sub _update_git_info ($$) {
my $env = { GIT_INDEX_FILE => $index };
run_die([@cmd, qw(read-tree -m -v -i), $self->{ref}], $env);
}
- run_die([@cmd, 'update-server-info'], undef);
+ run_die([@cmd, 'update-server-info']);
my $ibx = $self->{-inbox};
($ibx && $self->{path_type} eq '2/38') and eval {
require PublicInbox::SearchIdx;
my $s = PublicInbox::SearchIdx->new($ibx);
$s->index_sync({ ref => $self->{ref} });
};
- eval { run_die([@cmd, qw(gc --auto)], undef) } if $do_gc;
+ eval { run_die([@cmd, qw(gc --auto)]) } if $do_gc;
}
sub barrier {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] some low impact changes and cleanups
@ 2019-11-29 10:14 6% Eric Wong
2019-11-29 10:14 7% ` [PATCH 7/7] import: (cleanup) drop redundant env arg to run_die Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-11-29 10:14 UTC (permalink / raw)
To: meta
Some other changes coming in the next few days, I hope;
but the straightforward stuff, first...
Eric Wong (7):
t: localize the PI_CONFIG env
t/common: set $0 when running script w/o fork
ds: ->Reset initializes $nextq
TODO: update and add a few more items
tests: don't repeatly validate NEWS.atom
spawn: remove support for clearing the env
import: (cleanup) drop redundant env arg to run_die
.gitignore | 1 +
Documentation/include.mk | 5 +++--
TODO | 12 +++++++++---
lib/PublicInbox/DS.pm | 5 +++--
lib/PublicInbox/Import.pm | 4 ++--
lib/PublicInbox/Spawn.pm | 12 +-----------
t/common.perl | 1 +
t/indexlevels-mirror.t | 1 +
t/spawn.t | 10 ----------
t/xcpdb-reshard.t | 1 +
10 files changed, 22 insertions(+), 30 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-11-29 10:14 6% [PATCH 0/7] some low impact changes and cleanups Eric Wong
2019-11-29 10:14 7% ` [PATCH 7/7] import: (cleanup) drop redundant env arg to run_die Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).