From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 466981F93D for ; Fri, 29 Nov 2019 10:14:15 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 7/7] import: (cleanup) drop redundant env arg to run_die Date: Fri, 29 Nov 2019 10:14:14 +0000 Message-Id: <20191129101414.343-8-e@80x24.org> In-Reply-To: <20191129101414.343-1-e@80x24.org> References: <20191129101414.343-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: run_die() doesn't require an $env arg, so there's no point passing "undef" to it. --- lib/PublicInbox/Import.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm index 8a369ee4..46de09c4 100644 --- a/lib/PublicInbox/Import.pm +++ b/lib/PublicInbox/Import.pm @@ -178,14 +178,14 @@ sub _update_git_info ($$) { my $env = { GIT_INDEX_FILE => $index }; run_die([@cmd, qw(read-tree -m -v -i), $self->{ref}], $env); } - run_die([@cmd, 'update-server-info'], undef); + run_die([@cmd, 'update-server-info']); my $ibx = $self->{-inbox}; ($ibx && $self->{path_type} eq '2/38') and eval { require PublicInbox::SearchIdx; my $s = PublicInbox::SearchIdx->new($ibx); $s->index_sync({ ref => $self->{ref} }); }; - eval { run_die([@cmd, qw(gc --auto)], undef) } if $do_gc; + eval { run_die([@cmd, qw(gc --auto)]) } if $do_gc; } sub barrier {