user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 7/7] import: (cleanup) drop redundant env arg to run_die
Date: Fri, 29 Nov 2019 10:14:14 +0000	[thread overview]
Message-ID: <20191129101414.343-8-e@80x24.org> (raw)
In-Reply-To: <20191129101414.343-1-e@80x24.org>

run_die() doesn't require an $env arg, so there's no
point passing "undef" to it.
---
 lib/PublicInbox/Import.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 8a369ee4..46de09c4 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -178,14 +178,14 @@ sub _update_git_info ($$) {
 		my $env = { GIT_INDEX_FILE => $index };
 		run_die([@cmd, qw(read-tree -m -v -i), $self->{ref}], $env);
 	}
-	run_die([@cmd, 'update-server-info'], undef);
+	run_die([@cmd, 'update-server-info']);
 	my $ibx = $self->{-inbox};
 	($ibx && $self->{path_type} eq '2/38') and eval {
 		require PublicInbox::SearchIdx;
 		my $s = PublicInbox::SearchIdx->new($ibx);
 		$s->index_sync({ ref => $self->{ref} });
 	};
-	eval { run_die([@cmd, qw(gc --auto)], undef) } if $do_gc;
+	eval { run_die([@cmd, qw(gc --auto)]) } if $do_gc;
 }
 
 sub barrier {

      parent reply	other threads:[~2019-11-29 10:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 10:14 [PATCH 0/7] some low impact changes and cleanups Eric Wong
2019-11-29 10:14 ` [PATCH 1/7] t: localize the PI_CONFIG env Eric Wong
2019-11-29 10:14 ` [PATCH 2/7] t/common: set $0 when running script w/o fork Eric Wong
2019-11-29 10:14 ` [PATCH 3/7] ds: ->Reset initializes $nextq Eric Wong
2019-11-29 10:14 ` [PATCH 4/7] TODO: update and add a few more items Eric Wong
2019-11-29 10:14 ` [PATCH 5/7] tests: don't repeatly validate NEWS.atom Eric Wong
2019-11-29 10:14 ` [PATCH 6/7] spawn: remove support for clearing the env Eric Wong
2019-11-29 10:14 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191129101414.343-8-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).