* Re: [PATCH] git: write_all: remove leftover debug messages
2023-01-05 1:44 14% ` [PATCH] git: write_all: remove leftover debug messages Eric Wong
@ 2023-01-05 7:32 7% ` Chris Brannon
0 siblings, 0 replies; 2+ results
From: Chris Brannon @ 2023-01-05 7:32 UTC (permalink / raw)
To: Eric Wong; +Cc: meta
Eric Wong <e@80x24.org> writes:
> Subject: [PATCH] git: write_all: remove leftover debug messages
>
> I used these messages during development to verify Alpine was
> triggering the intended codepaths. They're no longer necessary
> and just noise at this point.
>
> Reported-by: Chris Brannon <chris@the-brannons.com>
> Tested-by: Chris Brannon <chris@the-brannons.com>
> Fixes: d4ba8828ab23 ("git: fix asynchronous batching for deep pipelines")
> ---
> lib/PublicInbox/Git.pm | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks!
-- Chris
^ permalink raw reply [relevance 7%]
* [PATCH] git: write_all: remove leftover debug messages
@ 2023-01-05 1:44 14% ` Eric Wong
2023-01-05 7:32 7% ` Chris Brannon
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-01-05 1:44 UTC (permalink / raw)
To: Chris Brannon; +Cc: meta
Chris Brannon <chris@the-brannons.com> wrote:
> The conversion seems to have been successful, but it logged very many of
> the following:
> E: Resource temporarily unavailable at
> /usr/share/perl5/vendor_perl/PublicInbox/Git.pm line 320.
>
> I'm sorry, I didn't count how many. It seemed like multiple screenfuls
> at least.
Oops, yeah. Just leftover debug messages that never triggered
on my FreeBSD and Debian systems. Will push this out:
---------8<----------
Subject: [PATCH] git: write_all: remove leftover debug messages
I used these messages during development to verify Alpine was
triggering the intended codepaths. They're no longer necessary
and just noise at this point.
Reported-by: Chris Brannon <chris@the-brannons.com>
Fixes: d4ba8828ab23 ("git: fix asynchronous batching for deep pipelines")
---
lib/PublicInbox/Git.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 86b80a4e..c7f82ba2 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -315,11 +315,10 @@ sub write_all {
my $w = syswrite($out, $buf);
if (defined $w) {
return if $w == length($buf);
- warn "chop: $w";
substr($buf, 0, $w, ''); # sv_chop
} elsif ($! != EAGAIN) {
$self->fail("write: $!");
- } else { warn "E: $!" }
+ }
$read_step->($self, $inflight);
} while (1);
}
^ permalink raw reply related [relevance 14%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-12-21 12:21 public-inbox-convert hangs on systems using musl libc Eric Wong
2022-12-21 13:46 ` Chris Brannon
2022-12-21 19:48 ` Eric Wong
2022-12-21 20:46 ` Chris Brannon
2022-12-21 21:11 ` Eric Wong
2022-12-21 22:17 ` Chris Brannon
2022-12-21 23:22 ` [PATCH] git: cap MAX_INFLIGHT value to POSIX minimum Eric Wong
2022-12-21 23:57 ` Chris Brannon
2023-01-04 3:49 ` [PATCH] git: fix asynchronous batching for deep pipelines Eric Wong
2023-01-05 1:08 ` Chris Brannon
2023-01-05 1:44 14% ` [PATCH] git: write_all: remove leftover debug messages Eric Wong
2023-01-05 7:32 7% ` Chris Brannon
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).