From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D39D31F47C; Thu, 5 Jan 2023 01:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1672883120; bh=8uxh3PR3NYo5NRn7gCCjDC+0rE1s3zi/SxkHvol/4xY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pYH8CApBPvjpa2HwQHXR8TgzgYGBnpRPnaZZcSR/XyswieONez7yH4VXt/353mUF8 3IDUHbT0wjPrTMHuU3Dl65b+OSAgfwzA2AKk9T1sKkeE2m9NNR4xmkkem07jx7WIyn 7g4aSrsJyYbzkhXrU/F1PQ3QQZSG7X5d3JOqvtFk= Date: Thu, 5 Jan 2023 01:44:59 +0000 From: Eric Wong To: Chris Brannon Cc: meta@public-inbox.org Subject: [PATCH] git: write_all: remove leftover debug messages Message-ID: <20230105014459.M765102@dcvr> References: <20221221122102.M600156@dcvr> <871qosna30.fsf@the-brannons.com> <20221221194855.GA5179@dcvr> <87mt7glc23.fsf@the-brannons.com> <20221221211114.M412849@dcvr> <87edssl7u0.fsf@the-brannons.com> <20221221232210.M865188@dcvr> <877cykl387.fsf@the-brannons.com> <20230104034934.M147841@dcvr> <87tu15dbz3.fsf@the-brannons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87tu15dbz3.fsf@the-brannons.com> List-Id: Chris Brannon wrote: > The conversion seems to have been successful, but it logged very many of > the following: > E: Resource temporarily unavailable at > /usr/share/perl5/vendor_perl/PublicInbox/Git.pm line 320. > > I'm sorry, I didn't count how many. It seemed like multiple screenfuls > at least. Oops, yeah. Just leftover debug messages that never triggered on my FreeBSD and Debian systems. Will push this out: ---------8<---------- Subject: [PATCH] git: write_all: remove leftover debug messages I used these messages during development to verify Alpine was triggering the intended codepaths. They're no longer necessary and just noise at this point. Reported-by: Chris Brannon Fixes: d4ba8828ab23 ("git: fix asynchronous batching for deep pipelines") --- lib/PublicInbox/Git.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm index 86b80a4e..c7f82ba2 100644 --- a/lib/PublicInbox/Git.pm +++ b/lib/PublicInbox/Git.pm @@ -315,11 +315,10 @@ sub write_all { my $w = syswrite($out, $buf); if (defined $w) { return if $w == length($buf); - warn "chop: $w"; substr($buf, 0, $w, ''); # sv_chop } elsif ($! != EAGAIN) { $self->fail("write: $!"); - } else { warn "E: $!" } + } $read_step->($self, $inflight); } while (1); }