user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Chris Brannon <chris@the-brannons.com>
Cc: meta@public-inbox.org
Subject: Re: public-inbox-convert hangs on systems using musl libc
Date: Wed, 21 Dec 2022 12:21:02 +0000	[thread overview]
Message-ID: <20221221122102.M600156@dcvr> (raw)
In-Reply-To: <875ye5m1wo.fsf@the-brannons.com>

Chris Brannon <chris@the-brannons.com> wrote:
> I can reproduce it reliably on both Alpine Linux and the musl variant of
> Void Linux.  Just clone a mirror of public-inbox.org/meta and try and
> convert it:
> 
> $ git clone --mirror https://public-inbox.org/meta
> $ public-inbox-convert meta metanew
> 
> If I pass --no-index, the process is successful.
> 
> This is a deadlock of some sort, because during the hang, git cat-file
> is blocked on write and other things are blocked on read.

I've requested some packages w/ cfarm admins to test with.

Do you know which pipes are which?  "lsof -p $PID +E" can help
with connectivity checking, as can script/dtas-graph in
https://80x24.org/dtas.git if you have Graph::Easy

What's curious is all the code paths should be independent of
stdio buffering, so I wouldn't think libc differences would
matter...

I also just did the above meta conversion on FreeBSD w/o problems.

> That's as far as I have gotten with debugging it.

Some shots in the dark:

1. force read pipe on our end to be non-blocking

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 882a9a4a..b239ceb9 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -143,6 +143,7 @@ sub _bidi_pipe {
 		fcntl($out_w, 1031, 4096);
 		fcntl($in_r, 1031, 4096) if $batch eq '--batch-check';
 	}
+	$in_r->blocking(0);
 	$self->{$out} = $out_w;
 	$self->{$in} = $in_r;
 }

2. Tweak $PIPE_BUFSIZ and/or MAX_INFLIGHT to smaller values.  e.g.

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 882a9a4a..ec40edd7 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -23,13 +23,12 @@ use Carp qw(croak carp);
 use Digest::SHA ();
 use PublicInbox::DS qw(dwaitpid);
 our @EXPORT_OK = qw(git_unquote git_quote);
-our $PIPE_BUFSIZ = 65536; # Linux default
+our $PIPE_BUFSIZ = 4096; # Linux default
 our $in_cleanup;
 our $RDTIMEO = 60_000; # milliseconds
 our $async_warn; # true in read-only daemons
 
-use constant MAX_INFLIGHT => (POSIX::PIPE_BUF * 3) /
-	65; # SHA-256 hex size + "\n" in preparation for git using non-SHA1
+use constant MAX_INFLIGHT => 4;
 
 my %GIT_ESC = (
 	a => "\a",


MAX_INFLIGHT could go down to 1 outside of t/git.t, I think...
But my sleep deprived mind isn't finding anything that jumps out...

  reply	other threads:[~2022-12-21 12:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 11:28 public-inbox-convert hangs on systems using musl libc Chris Brannon
2022-12-21 12:21 ` Eric Wong [this message]
2022-12-21 13:46   ` Chris Brannon
2022-12-21 19:48     ` Eric Wong
2022-12-21 20:46       ` Chris Brannon
2022-12-21 21:11         ` Eric Wong
2022-12-21 22:17           ` Chris Brannon
2022-12-21 23:22             ` [PATCH] git: cap MAX_INFLIGHT value to POSIX minimum Eric Wong
2022-12-21 23:57               ` Chris Brannon
2023-01-04  3:49                 ` [PATCH] git: fix asynchronous batching for deep pipelines Eric Wong
2023-01-05  1:08                   ` Chris Brannon
2023-01-05  1:44                     ` [PATCH] git: write_all: remove leftover debug messages Eric Wong
2023-01-05  7:32                       ` Chris Brannon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221221122102.M600156@dcvr \
    --to=e@80x24.org \
    --cc=chris@the-brannons.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).