From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] www: inbox: favor "pop3://" over "pop://"
Date: Thu, 11 Aug 2022 20:00:20 +0000 [thread overview]
Message-ID: <20220811200021.12662-2-e@80x24.org> (raw)
In-Reply-To: <20220811200021.12662-1-e@80x24.org>
curl only supports "pop3://" and "pop3s://", despite RFC 2384
existing for "pop://". AFAIK, there's no RFCs for "pop3://"
and "pop3s://", but please let us know if there are.
In any case, real-world cases like curl are more relevant.
---
lib/PublicInbox/Inbox.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 3f70e69d..1f7f982d 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -285,9 +285,9 @@ sub pop3_url {
my $group = $self->{newsgroup};
my @urls;
($ps && $group) and
- @urls = map { m!\Apops?://! ? $_ : "pop://$_" } @$ps;
+ @urls = map { m!\Apop3?s?://! ? $_ : "pop3://$_" } @$ps;
if (my $mi = $self->{'pop3mirror'}) {
- my @m = map { m!\Apops?://! ? $_ : "pop://$_" } @$mi;
+ my @m = map { m!\Apop3?s?://! ? $_ : "pop3://$_" } @$mi;
my %seen; # List::Util::uniq requires Perl 5.26+
@urls = grep { !$seen{$_}++ } (@urls, @m);
}
next prev parent reply other threads:[~2022-08-11 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 20:00 [PATCH 0/2] a few more POP3 bits Eric Wong
2022-08-11 20:00 ` Eric Wong [this message]
2022-08-11 20:00 ` [PATCH 2/2] pop3d: enable native fcntl locks on all *BSDs Eric Wong
2022-08-11 21:57 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811200021.12662-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).