user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH 2/2] pop3d: enable native fcntl locks on all *BSDs
Date: Thu, 11 Aug 2022 20:00:21 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> we've already done for the simpler case of mbox locking in lei.
I've just confirmed NetBSD and OpenBSD share the same "struct flock"
with FreeBSD, and assume DragonflyBSD is the same.  sizeof(pid_t) == 4
in all places I've checked, and it's unlikely we'll need 64-bit
pid_t any time soon...
 lib/PublicInbox/ | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 7432a964..8aa16907 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -14,7 +14,7 @@ use PublicInbox::Syscall;
 use File::Temp 0.19 (); # 0.19 for ->newdir
 my @FLOCK;
-if ($^O eq 'linux' || $^O eq 'freebsd') {
+if ($^O eq 'linux' || $^O =~ /bsd/) {
 	require Config;
 	my $off_t;
 	my $sz = $Config::Config{lseeksize};
@@ -27,7 +27,7 @@ if ($^O eq 'linux' || $^O eq 'freebsd') {
 		if ($^O eq 'linux') {
 			@FLOCK = ("ss\@8$off_t$off_t\@32",
 				qw(l_type l_whence l_start l_len));
-		} elsif ($^O eq 'freebsd') {
+		} elsif ($^O eq /bsd/) {
 			@FLOCK = ("${off_t}${off_t}lss\@256",
 				qw(l_start l_len l_pid l_type l_whence));

  parent reply	other threads:[~2022-08-11 20:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 20:00 [PATCH 0/2] a few more POP3 bits Eric Wong
2022-08-11 20:00 ` [PATCH 1/2] www: inbox: favor "pop3://" over "pop://" Eric Wong
2022-08-11 20:00 ` Eric Wong [this message]
2022-08-11 21:57   ` [PATCH 2/2] pop3d: enable native fcntl locks on all *BSDs Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).