user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 2/2] pop3d: enable native fcntl locks on all *BSDs
Date: Thu, 11 Aug 2022 21:57:35 +0000	[thread overview]
Message-ID: <20220811215735.M757147@dcvr> (raw)
In-Reply-To: <20220811200021.12662-3-e@80x24.org>

Eric Wong <e@80x24.org> wrote:
> --- a/lib/PublicInbox/POP3D.pm
> +++ b/lib/PublicInbox/POP3D.pm
> @@ -27,7 +27,7 @@ if ($^O eq 'linux' || $^O eq 'freebsd') {
>  		if ($^O eq 'linux') {
>  			@FLOCK = ("ss\@8$off_t$off_t\@32",
>  				qw(l_type l_whence l_start l_len));
> -		} elsif ($^O eq 'freebsd') {
> +		} elsif ($^O eq /bsd/) {
>  			@FLOCK = ("${off_t}${off_t}lss\@256",
>  				qw(l_start l_len l_pid l_type l_whence));
>  		}

Erm..., will squash the patch below in :x

diff --git a/lib/PublicInbox/POP3D.pm b/lib/PublicInbox/POP3D.pm
index 8aa16907..3fc85efc 100644
--- a/lib/PublicInbox/POP3D.pm
+++ b/lib/PublicInbox/POP3D.pm
@@ -27,7 +27,7 @@ if ($^O eq 'linux' || $^O =~ /bsd/) {
 		if ($^O eq 'linux') {
 			@FLOCK = ("ss\@8$off_t$off_t\@32",
 				qw(l_type l_whence l_start l_len));
-		} elsif ($^O eq /bsd/) {
+		} elsif ($^O =~ /bsd/) {
 			@FLOCK = ("${off_t}${off_t}lss\@256",
 				qw(l_start l_len l_pid l_type l_whence));
 		}

      reply	other threads:[~2022-08-11 21:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 20:00 [PATCH 0/2] a few more POP3 bits Eric Wong
2022-08-11 20:00 ` [PATCH 1/2] www: inbox: favor "pop3://" over "pop://" Eric Wong
2022-08-11 20:00 ` [PATCH 2/2] pop3d: enable native fcntl locks on all *BSDs Eric Wong
2022-08-11 21:57   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811215735.M757147@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).