user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] msg_iter: support read-only elements
@ 2016-06-17  0:21 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-06-17  0:21 UTC (permalink / raw)
  To: meta

Apparently, it's possible to have read-only bodies in
Email::MIME objects.  Haven't gotten a chance to reliably
reproduce it, though...
---
 lib/PublicInbox/MsgIter.pm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/MsgIter.pm b/lib/PublicInbox/MsgIter.pm
index e0127ab..ef0d209 100644
--- a/lib/PublicInbox/MsgIter.pm
+++ b/lib/PublicInbox/MsgIter.pm
@@ -7,6 +7,7 @@ use warnings;
 use base qw(Exporter);
 our @EXPORT = qw(msg_iter);
 use Email::MIME;
+use Scalar::Util qw(readonly);
 
 # Workaround Email::MIME versions without
 # commit dcef9be66c49ae89c7a5027a789bbbac544499ce
@@ -36,7 +37,14 @@ sub msg_iter ($$) {
 				@parts = (@sub, @parts);
 			} else {
 				if ($extra_nl) {
-					${$part->{body}} .= $part->{mycrlf};
+					my $lf = $part->{mycrlf};
+					my $bref = $part->{body};
+					if (readonly($$bref)) {
+						my $s = $$bref . $lf;
+						$part->{body} = \$s;
+					} else {
+						$$bref .= $lf;
+					}
 				}
 				$cb->($p);
 			}

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-06-17  0:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17  0:21 [PATCH] msg_iter: support read-only elements Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).