From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] msg_iter: support read-only elements
Date: Fri, 17 Jun 2016 00:21:08 +0000 [thread overview]
Message-ID: <20160617002108.31320-1-e@80x24.org> (raw)
Apparently, it's possible to have read-only bodies in
Email::MIME objects. Haven't gotten a chance to reliably
reproduce it, though...
---
lib/PublicInbox/MsgIter.pm | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/MsgIter.pm b/lib/PublicInbox/MsgIter.pm
index e0127ab..ef0d209 100644
--- a/lib/PublicInbox/MsgIter.pm
+++ b/lib/PublicInbox/MsgIter.pm
@@ -7,6 +7,7 @@ use warnings;
use base qw(Exporter);
our @EXPORT = qw(msg_iter);
use Email::MIME;
+use Scalar::Util qw(readonly);
# Workaround Email::MIME versions without
# commit dcef9be66c49ae89c7a5027a789bbbac544499ce
@@ -36,7 +37,14 @@ sub msg_iter ($$) {
@parts = (@sub, @parts);
} else {
if ($extra_nl) {
- ${$part->{body}} .= $part->{mycrlf};
+ my $lf = $part->{mycrlf};
+ my $bref = $part->{body};
+ if (readonly($$bref)) {
+ my $s = $$bref . $lf;
+ $part->{body} = \$s;
+ } else {
+ $$bref .= $lf;
+ }
}
$cb->($p);
}
reply other threads:[~2016-06-17 0:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617002108.31320-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).