From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 6/7] SearchMsg: avoid encoding Message-IDs
Date: Fri, 4 Sep 2015 02:37:55 +0000 [thread overview]
Message-ID: <20150904023755.GA22016@dcvr.yhbt.net> (raw)
In-Reply-To: <1441333091-32421-7-git-send-email-e@80x24.org>
Eric Wong <e@80x24.org> wrote:
> - my $refs = $self->{references_sorted};
> - my $mime = Email::MIME->create(header_str => \@h);
> + if (my $refs = $self->{references_sorted}) {
> + push @h, [ References => $refs ];
And my Perl syntax knowledge is weak:
--- a/lib/PublicInbox/SearchMsg.pm
+++ b/lib/PublicInbox/SearchMsg.pm
@@ -141,7 +141,7 @@ sub mini_mime {
'X-PI-TS' => $self->ts,
);
if (my $refs = $self->{references_sorted}) {
- push @h, [ References => $refs ];
+ push @h, References => $refs;
}
my $mime = Email::MIME->create(header_str => \@hs, header => \@h);
my $h = $mime->header_obj;
Will squash.
next prev parent reply other threads:[~2015-09-04 2:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 2:18 [PATCH 0/7] new index and misc fixes Eric Wong
2015-09-04 2:18 ` [PATCH 1/7] doc: design_www: more accessibility guidelines Eric Wong
2015-09-04 2:18 ` [PATCH 2/7] index: use message threading if search is available Eric Wong
2015-09-04 2:18 ` [PATCH 3/7] consolidate thread sorting in view Eric Wong
2015-09-04 2:18 ` [PATCH 4/7] extmsg: close HTML tag in response Eric Wong
2015-09-04 2:18 ` [PATCH 5/7] view: avoid attempting to find "subject dummy" Eric Wong
2015-09-04 2:18 ` [PATCH 6/7] SearchMsg: avoid encoding Message-IDs Eric Wong
2015-09-04 2:37 ` Eric Wong [this message]
2015-09-04 2:18 ` [PATCH 7/7] view: do not generate anchors in thread views Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904023755.GA22016@dcvr.yhbt.net \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).