From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C41D8200EE; Fri, 4 Sep 2015 02:37:55 +0000 (UTC) Date: Fri, 4 Sep 2015 02:37:55 +0000 From: Eric Wong To: meta@public-inbox.org Subject: Re: [PATCH 6/7] SearchMsg: avoid encoding Message-IDs Message-ID: <20150904023755.GA22016@dcvr.yhbt.net> References: <1441333091-32421-1-git-send-email-e@80x24.org> <1441333091-32421-7-git-send-email-e@80x24.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441333091-32421-7-git-send-email-e@80x24.org> List-Id: Eric Wong wrote: > - my $refs = $self->{references_sorted}; > - my $mime = Email::MIME->create(header_str => \@h); > + if (my $refs = $self->{references_sorted}) { > + push @h, [ References => $refs ]; And my Perl syntax knowledge is weak: --- a/lib/PublicInbox/SearchMsg.pm +++ b/lib/PublicInbox/SearchMsg.pm @@ -141,7 +141,7 @@ sub mini_mime { 'X-PI-TS' => $self->ts, ); if (my $refs = $self->{references_sorted}) { - push @h, [ References => $refs ]; + push @h, References => $refs; } my $mime = Email::MIME->create(header_str => \@hs, header => \@h); my $h = $mime->header_obj; Will squash.