user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/7] consolidate thread sorting in view
Date: Fri,  4 Sep 2015 02:18:07 +0000	[thread overview]
Message-ID: <1441333091-32421-4-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1441333091-32421-1-git-send-email-e@80x24.org>

This is a display subroutine so it should not be in our thread
monkey-patching package, but instead in the view package.

Hopefully one day in the future, Mail::Thread will be maintained
again and we'll no longer need PublicInbox::Thread at all.
---
 lib/PublicInbox/Thread.pm | 7 -------
 lib/PublicInbox/View.pm   | 9 ++++++++-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/PublicInbox/Thread.pm b/lib/PublicInbox/Thread.pm
index a3dedf5..781ffff 100644
--- a/lib/PublicInbox/Thread.pm
+++ b/lib/PublicInbox/Thread.pm
@@ -17,13 +17,6 @@ if ($Mail::Thread::VERSION <= 2.55) {
 	eval q(sub _container_class { 'PublicInbox::Thread::Container' });
 }
 
-sub sort_ts {
-	sort {
-		(eval { $a->topmost->message->header('X-PI-TS') } || 0) <=>
-		(eval { $b->topmost->message->header('X-PI-TS') } || 0)
-	} @_;
-}
-
 package PublicInbox::Thread::Container;
 use strict;
 use warnings;
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index ee5ba20..68adbd7 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -662,7 +662,7 @@ sub thread_results {
 	no warnings 'once';
 	$Mail::Thread::nosubject = $nosubject;
 	$th->thread;
-	$th->order(*PublicInbox::Thread::sort_ts);
+	$th->order(*sort_ts);
 	$th
 }
 
@@ -747,6 +747,13 @@ sub inline_dump {
 	inline_dump($dst, $state, $upfx, $node->next, $level);
 }
 
+sub sort_ts {
+	sort {
+		(eval { $a->topmost->message->header('X-PI-TS') } || 0) <=>
+		(eval { $b->topmost->message->header('X-PI-TS') } || 0)
+	} @_;
+}
+
 sub rsort_ts {
 	sort {
 		(eval { $b->topmost->message->header('X-PI-TS') } || 0) <=>
-- 
EW


  parent reply	other threads:[~2015-09-04  2:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04  2:18 [PATCH 0/7] new index and misc fixes Eric Wong
2015-09-04  2:18 ` [PATCH 1/7] doc: design_www: more accessibility guidelines Eric Wong
2015-09-04  2:18 ` [PATCH 2/7] index: use message threading if search is available Eric Wong
2015-09-04  2:18 ` Eric Wong [this message]
2015-09-04  2:18 ` [PATCH 4/7] extmsg: close HTML tag in response Eric Wong
2015-09-04  2:18 ` [PATCH 5/7] view: avoid attempting to find "subject dummy" Eric Wong
2015-09-04  2:18 ` [PATCH 6/7] SearchMsg: avoid encoding Message-IDs Eric Wong
2015-09-04  2:37   ` Eric Wong
2015-09-04  2:18 ` [PATCH 7/7] view: do not generate anchors in thread views Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441333091-32421-4-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).