user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH 2/2] feed: (cleanup) avoid redundant ->message call
Date: Sun,  7 Sep 2014 22:58:36 +0000	[thread overview]
Message-ID: <1410130716-9033-2-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1410130716-9033-1-git-send-email-e@80x24.org>

Avoid redundant subroutine calls as their costs tend to add up.
---
 lib/PublicInbox/Feed.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 1f1c0d6..350cc65 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -286,8 +286,8 @@ sub add_to_feed {
 
 sub dump_msg {
 	my ($self, $level, $html, $now, $seen) = @_;
-	if ($self->message) {
-		my $mime = $self->message;
+	my $mime = $self->message;
+	if ($mime) {
 		$$html .=
 		    PublicInbox::View->index_entry($mime, $now, $level, $seen);
 	}
-- 
EW


      reply	other threads:[~2014-09-07 22:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-07 22:58 [PATCH 1/2] feed: sort child messages (forward) chronologically Eric Wong
2014-09-07 22:58 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410130716-9033-2-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).