From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 5C9B21FD76; Sun, 7 Sep 2014 22:58:41 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Cc: Eric Wong Subject: [PATCH 2/2] feed: (cleanup) avoid redundant ->message call Date: Sun, 7 Sep 2014 22:58:36 +0000 Message-Id: <1410130716-9033-2-git-send-email-e@80x24.org> X-Mailer: git-send-email 2.1.0.3.g7cd1957.dirty In-Reply-To: <1410130716-9033-1-git-send-email-e@80x24.org> References: <1410130716-9033-1-git-send-email-e@80x24.org> List-Id: Avoid redundant subroutine calls as their costs tend to add up. --- lib/PublicInbox/Feed.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm index 1f1c0d6..350cc65 100644 --- a/lib/PublicInbox/Feed.pm +++ b/lib/PublicInbox/Feed.pm @@ -286,8 +286,8 @@ sub add_to_feed { sub dump_msg { my ($self, $level, $html, $now, $seen) = @_; - if ($self->message) { - my $mime = $self->message; + my $mime = $self->message; + if ($mime) { $$html .= PublicInbox::View->index_entry($mime, $now, $level, $seen); } -- EW