user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH 1/2] feed: sort child messages (forward) chronologically
Date: Sun,  7 Sep 2014 22:58:35 +0000	[thread overview]
Message-ID: <1410130716-9033-1-git-send-email-e@80x24.org> (raw)

Only root messages should be sorted in reverse chronological order,
child messages should be chronological.  This gives precedence to
_topics_, but also for initial replies.

This improves readability when several messages appear at the same
nesting level, and helps git patch series' appear correctly as:

	[PATCH 0/3] ...
		[PATCH 1/3] ...
		[PATCH 2/3] ...
		[PATCH 3/3] ...

Instead of (what it was previously):

	[PATCH 0/3] ...
		[PATCH 3/3] ...
		[PATCH 2/3] ...
		[PATCH 1/3] ...
---
 lib/PublicInbox/Feed.pm | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 646c85c..1f1c0d6 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -77,15 +77,21 @@ sub generate_html_index {
 		$feed_opts->{atomurl} . '" type="application/atom+xml"/>' .
 		'</head><body>' . PRE_WRAP;
 
-	# sort by date, most recent at top
+	# sort child messages in chronological order
 	$th->order(sub {
 		sort {
-			$b->topmost->message->header('X-PI-Date') <=>
-			$a->topmost->message->header('X-PI-Date')
+			$a->topmost->message->header('X-PI-Date') <=>
+			$b->topmost->message->header('X-PI-Date')
 		} @_;
 	});
+
 	my %seen;
-	dump_msg($_, 0, \$html, time, \%seen) for $th->rootset;
+	# except we sort top-level messages reverse chronologically
+	for (sort { (eval { $b->message->header('X-PI-Date') } || 0) <=>
+		    (eval { $a->message->header('X-PI-Date') } || 0)
+		  } $th->rootset) {
+		dump_msg($_, 0, \$html, time, \%seen);
+	}
 
 	Email::Address->purge_cache;
 
-- 
EW


             reply	other threads:[~2014-09-07 22:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-07 22:58 Eric Wong [this message]
2014-09-07 22:58 ` [PATCH 2/2] feed: (cleanup) avoid redundant ->message call Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410130716-9033-1-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).