unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: libc-alpha@sourceware.org, nd@arm.com
Subject: Re: riscv: fmax/fmin sNaN fix
Date: Tue, 20 Feb 2018 12:12:30 -0500	[thread overview]
Message-ID: <xnh8qbk2kh.fsf@greed.delorie.com> (raw)
In-Reply-To: <b680364d-83ef-48ba-1885-71e50ccc4845@arm.com> (message from Szabolcs Nagy on Tue, 20 Feb 2018 10:26:01 +0000)


Szabolcs Nagy <szabolcs.nagy@arm.com> writes:
> On 20/02/18 02:57, DJ Delorie wrote:
>> 
>> RISC-V's FPU follows the IEEE spec, not the POSIX spec.  This patch
>                             ^^^^^^^^^
> which one?
> (the next ieee revision will have different min/max operations)

The one that doesn't match POSIX :-)

The RISC-V fpu does this:

fmax (sNAN,4) -> 4

GLIBC expects this:

fmax (sNAN,4) -> qNAN

(hmm... maybe it follows posix, not ieee... whatever, it doesn't do what
glibc expects)

Note that the RISC-V ISA spec 2.2 documents the sNAN->qNAN behavior,
there's a patch for 2.3 that corrects it to match actual hardware.


  reply	other threads:[~2018-02-20 17:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20  2:57 riscv: fmax/fmin sNaN fix DJ Delorie
2018-02-20 10:26 ` Szabolcs Nagy
2018-02-20 17:12   ` DJ Delorie [this message]
2018-02-20 17:22   ` DJ Delorie
2018-02-21 10:44     ` Szabolcs Nagy
2018-02-21 17:25       ` DJ Delorie
2018-02-21 23:24         ` Carlos O'Donell
2018-02-22  0:24           ` DJ Delorie
2018-02-22 20:28             ` Carlos O'Donell
2018-02-22 20:34               ` DJ Delorie
2018-02-22 20:42                 ` Joseph Myers
2018-02-22 20:50                   ` Joseph Myers
2018-02-23  1:58                     ` DJ Delorie
2018-02-23  2:01                       ` Joseph Myers
2018-02-23  2:08                         ` DJ Delorie
2018-02-20 22:03   ` Richard Henderson
2018-02-20 23:11   ` Joseph Myers
2018-02-21 21:25 ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xnh8qbk2kh.fsf@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=nd@arm.com \
    --cc=szabolcs.nagy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).