From: DJ Delorie <dj@redhat.com>
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: riscv: fmax/fmin sNaN fix
Date: Wed, 21 Feb 2018 19:24:42 -0500 [thread overview]
Message-ID: <xnd10xvpkl.fsf@greed.delorie.com> (raw)
In-Reply-To: <dccb1599-59a7-18e1-3bf7-33e13474ef5a@redhat.com> (carlos@redhat.com)
"Carlos O'Donell" <carlos@redhat.com> writes:
> Patch review includes review of the commit messages for factual accuracy.
Please review the original changelog entry then ;-)
> * sysdeps/riscv/rvd/s_fmax.c (__fmax): Handle sNaNs correctly.
> * sysdeps/riscv/rvd/s_fmin.c (__fmin): Likewise.
> * sysdeps/riscv/rvf/s_fmaxf.c (__fmaxf): Likewise.
> * sysdeps/riscv/rvf/s_fminf.c (__fminf): Likewise.
That's actually functional, and doesn't mention anything about specs,
should be sufficient.
Original author: Andrew Waterman <andrew@sifive.com>
(plus or minus the "maintainers have automatic consensus" rules, of
course ;)
next prev parent reply other threads:[~2018-02-22 0:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 2:57 riscv: fmax/fmin sNaN fix DJ Delorie
2018-02-20 10:26 ` Szabolcs Nagy
2018-02-20 17:12 ` DJ Delorie
2018-02-20 17:22 ` DJ Delorie
2018-02-21 10:44 ` Szabolcs Nagy
2018-02-21 17:25 ` DJ Delorie
2018-02-21 23:24 ` Carlos O'Donell
2018-02-22 0:24 ` DJ Delorie [this message]
2018-02-22 20:28 ` Carlos O'Donell
2018-02-22 20:34 ` DJ Delorie
2018-02-22 20:42 ` Joseph Myers
2018-02-22 20:50 ` Joseph Myers
2018-02-23 1:58 ` DJ Delorie
2018-02-23 2:01 ` Joseph Myers
2018-02-23 2:08 ` DJ Delorie
2018-02-20 22:03 ` Richard Henderson
2018-02-20 23:11 ` Joseph Myers
2018-02-21 21:25 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnd10xvpkl.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).