From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: DJ Delorie Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: riscv: fmax/fmin sNaN fix Date: Wed, 21 Feb 2018 19:24:42 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519258969 3343 195.159.176.226 (22 Feb 2018 00:22:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Feb 2018 00:22:49 +0000 (UTC) Cc: libc-alpha@sourceware.org To: "Carlos O'Donell" Original-X-From: libc-alpha-return-90461-glibc-alpha=m.gmane.org@sourceware.org Thu Feb 22 01:22:45 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; q=dns; s=default; b=BG0vLho/VWUXnC+U hDpeT8qgWW+WeleXHh5XSjhJLA7pPF3FVfZh5TddMtezyHSOKzaMNRweMb+T1Jif WxusDxm/YiSzbt9RqrT/2yp3QC+iBb/xDV7YBwG3psRUvFE1xX7qkTdYokQ9ZE+T +WWQ4tpxH/dDElsObaHkTWDYvZg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; s=default; bh=29tJgL1Ab+ncGOEZ8rbCjG oeOOA=; b=xOv8pgfghYHhxCy+imMT0Ds31eaW325rR8g12UDA/UlX3ML6vz9nRV oBBE8l7GfuY5oaQvVmgglCgJAHJ95cftx0LMRYeBSsqJys7yhjgeOPt/RN+d7lfa R/1N5ostvawnCoAGpOyQ00qCV+GEj/YNlOfkmTbDzWsGmvw18kZJ0= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com In-Reply-To: (carlos@redhat.com) Xref: news.gmane.org gmane.comp.lib.glibc.alpha:82793 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoeeq-0000OG-UP for glibc-alpha@blaine.gmane.org; Thu, 22 Feb 2018 01:22:45 +0100 Received: (qmail 72580 invoked by alias); 22 Feb 2018 00:24:47 -0000 Received: (qmail 72569 invoked by uid 89); 22 Feb 2018 00:24:47 -0000 "Carlos O'Donell" writes: > Patch review includes review of the commit messages for factual accuracy. Please review the original changelog entry then ;-) > * sysdeps/riscv/rvd/s_fmax.c (__fmax): Handle sNaNs correctly. > * sysdeps/riscv/rvd/s_fmin.c (__fmin): Likewise. > * sysdeps/riscv/rvf/s_fmaxf.c (__fmaxf): Likewise. > * sysdeps/riscv/rvf/s_fminf.c (__fminf): Likewise. That's actually functional, and doesn't mention anything about specs, should be sufficient. Original author: Andrew Waterman (plus or minus the "maintainers have automatic consensus" rules, of course ;)