From: Mike FABIAN <mfabian@redhat.com>
To: Rafal Luzynski <digitalfreak@lingonborough.com>
Cc: libc-alpha@sourceware.org, Siddhesh Poyarekar <siddhesh@gotplt.org>
Subject: Re: [PATCH 2/2] Add new locale: ckb_IQ (Kurdish/Sorani spoken in Iraq) [BZ #9809]
Date: Wed, 15 Jan 2020 10:00:20 +0100 [thread overview]
Message-ID: <s9d8sm9hz6j.fsf@taka.site> (raw)
In-Reply-To: <92994978.1038459.1579039780291@poczta.nazwa.pl> (Rafal Luzynski's message of "Tue, 14 Jan 2020 23:09:40 +0100 (CET)")
Rafal Luzynski <digitalfreak@lingonborough.com> さんはかきました:
>> mon_grouping 3
>> -positive_sign ""
>> -negative_sign "<U002D>"
>> +positive_sign "+"
>> +negative_sign "-"
>
> This is not a simple change because it replaces an empty string
> in the positive_sign field with "+". Are you sure this is correct?
They said so in the bug report:
https://sourceware.org/bugzilla/show_bug.cgi?id=9809#c58
(In reply to Jwtiyar Nariman from comment #56)
> Thank you mike you your help is really appreciated
> I have pointed all my answers according to your question and suggestion to
> our locale as follow:
>
> 1. For positive sign and negative i agree with you let it be + and - .
Your original locale had the positive sign empty.
Probably a mistake. So I’ll make it + now.
>> [...]
>> -
>> LC_MESSAGES
>> -yesexpr "<U0628><U06D5><U06B5><U06CE>"
>> -noexpr "<U0646><U06D5><U062E><U06CE><U0631>"
>> +yesexpr "^[+1yY<U0628>]"
>> +noexpr "^[-0nN<U0646>]"
>
> Correct!
>
> Otherwise this patch is either correct or I am unable to verify.
> I don't give my "Reviewed-by" because this review is very incomplete.
> But unless anyone else opposes feel free to push it.
>
> Of course, we need a permission from Siddhesh (CC)
>
> Regards,
>
> Rafal
>
--
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。
next prev parent reply other threads:[~2020-01-15 9:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 9:26 [PATCH 2/2] Add new locale: ckb_IQ (Kurdish/Sorani spoken in Iraq) [BZ #9809] Mike FABIAN
2020-01-14 22:09 ` Rafal Luzynski
2020-01-15 2:32 ` Siddhesh Poyarekar
2020-01-15 9:01 ` Mike FABIAN
2020-01-15 9:18 ` Siddhesh Poyarekar
2020-01-15 9:00 ` Mike FABIAN [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-15 9:18 Mike FABIAN
2020-01-15 21:20 ` Rafal Luzynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s9d8sm9hz6j.fsf@taka.site \
--to=mfabian@redhat.com \
--cc=digitalfreak@lingonborough.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).