Re: [PATCH 2/2] Add new locale: ckb_IQ (Kurdish/Sorani spoken in Iraq) [BZ #9809]

[Rafal Luzynski <digitalfreak@lingonborough.com>]

I am unable to verify most of the changes here but I believe they
are correct.  Here are just few remarks:

14.01.2020 10:26 Mike FABIAN <mfabian@redhat.com> wrote:
> 
> 
> 
> Add new locale: ckb_IQ (Kurdish/Sorani spoken in Iraq) [BZ #9809]
> 
> Part 1 of the patch is what was submitted by the contributor.
> Part 2 are my fixes.
> 
> From 63a4478070ccaf9eb96ab6bfea147ea52e22073c Mon Sep 17 00:00:00 2001
> From: Mike FABIAN <mfabian@redhat.com>
> Date: Mon, 13 Jan 2020 10:12:07 +0100
> Subject: [PATCH 2/2] Fix  ckb_IQ; Add ckb_IQ to SUPPORTED file; Add
>  ckb_IQ.UTF-8.in collation test file;

If this has to be the subject line of the git commit comment then please
consider shortening it. What about this:

---------------------------------------------------
Fix ckb_IQ [BZ #9809]

Add ckb_IQ to SUPPORTED file.
Add ckb_IQ.UTF-8.in collation test file.
---------------------------------------------------

Also please make sure there are no double spaces unless necessary.
I am not sure if they were in your original message or they were added
by my email client.

Also it's nice to mention the bug number in both commits.

> 
> ---
>  localedata/Makefile        |   2 +
>  localedata/SUPPORTED       |   1 +
>  localedata/ckb_IQ.UTF-8.in | 105 +++++++++++
>  localedata/locales/ckb_IQ  | 369 +++++++------------------------------
>  4 files changed, 178 insertions(+), 299 deletions(-)
>  create mode 100644 localedata/ckb_IQ.UTF-8.in
> 
>  [...]
>  LC_MONETARY
> -int_curr_symbol       "<U0049><U0051><U0044><U0020>"
> +int_curr_symbol       "IQD "
>  currency_symbol       "<U062F><U002E><U0639>"
> -mon_decimal_point     "<U002E>"
> -mon_thousands_sep     "<U002C>"
> +mon_decimal_point     "."
> +mon_thousands_sep     ","

OK

>  mon_grouping	      3
> -positive_sign	      ""
> -negative_sign	      "<U002D>"
> +positive_sign	      "+"
> +negative_sign	      "-"

This is not a simple change because it replaces an empty string
in the positive_sign field with "+".  Are you sure this is correct?

>  [...]
> -
>  LC_MESSAGES
> -yesexpr  "<U0628><U06D5><U06B5><U06CE>"
> -noexpr   "<U0646><U06D5><U062E><U06CE><U0631>"
> +yesexpr  "^[+1yY<U0628>]"
> +noexpr   "^[-0nN<U0646>]"

Correct!

Otherwise this patch is either correct or I am unable to verify.
I don't give my "Reviewed-by" because this review is very incomplete.
But unless anyone else opposes feel free to push it.

Of course, we need a permission from Siddhesh (CC)

Regards,

Rafal