From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 20D011F466 for ; Wed, 15 Jan 2020 09:00:49 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=lG2lLM4O88Bzjmy5tVp5SQ7lYECFNz+9JtgRdOpKqbI xKf1qPq/6ClcAIEE4XR3UhM5xa/o0AhhZkx3Fk5d0q9WeYHJj49+B0sgeuuCH5dM wMwX4v9BExoU2/gHmJ+GVy2OCmNnUs8fYtIH4Gts1L33cKJTCOj+hYNVnkl7LgGI = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=LIL057g15QrCUFKrTDG8v395aRA=; b=NVvOIAmlUv25+In86 WaFw8FLAaFNuHRnuwtvn0wduVDRaazsG2SlBCjFRJ5puXcAM5EsiV0NARjsE7wCw aVG7whhGWeduQq8X4d2Z7GeT9NqaFvMtTMQTGwB3EcmkrOyPw7vjdJEBrYpRWo3E SVPno0Fji6bMsWZaxvjf14iHO4= Received: (qmail 107256 invoked by alias); 15 Jan 2020 09:00:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 107127 invoked by uid 89); 15 Jan 2020 09:00:41 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579078825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QeCmfzVaLxC4eU29+u2KDQxxGkbIxnW2WFX9rAmvxYs=; b=Oz8xoA1zNYnyqXiunP2Sbm8rOl3Th9IAALX7lcBiuYdjgFiuWh59Gou3/c5ZgZQPtptoLE e15TddSkp8S+Bqxs2Y6M6wqZrOx7yqm6LVJ2FnkuLCuf7DnHJLYGS0q2BvLnhE9tcT6wUb XyuiQtXVoD9hmAiE/j1CaOqX8r6SYJE= From: Mike FABIAN To: Rafal Luzynski Cc: libc-alpha@sourceware.org, Siddhesh Poyarekar Subject: Re: [PATCH 2/2] Add new locale: ckb_IQ (Kurdish/Sorani spoken in Iraq) [BZ #9809] References: <92994978.1038459.1579039780291@poczta.nazwa.pl> Date: Wed, 15 Jan 2020 10:00:20 +0100 In-Reply-To: <92994978.1038459.1579039780291@poczta.nazwa.pl> (Rafal Luzynski's message of "Tue, 14 Jan 2020 23:09:40 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Rafal Luzynski =E3=81=95=E3=82=93=E3=81=AF= =E3=81=8B=E3=81=8D=E3=81=BE=E3=81=97=E3=81=9F: >> mon_grouping=09 3 >> -positive_sign=09 "" >> -negative_sign=09 "" >> +positive_sign=09 "+" >> +negative_sign=09 "-" > > This is not a simple change because it replaces an empty string > in the positive_sign field with "+". Are you sure this is correct? They said so in the bug report: https://sourceware.org/bugzilla/show_bug.cgi?id=3D9809#c58 (In reply to Jwtiyar Nariman from comment #56) > Thank you mike you your help is really appreciated > I have pointed all my answers according to your question and suggesti= on to > our locale as follow: >=20 > 1. For positive sign and negative i agree with you let it be + and - = . =20 Your original locale had the positive sign empty. Probably a mistake. So I=E2=80=99ll make it + now. >> [...] >> - >> LC_MESSAGES >> -yesexpr "" >> -noexpr "" >> +yesexpr "^[+1yY]" >> +noexpr "^[-0nN]" > > Correct! > > Otherwise this patch is either correct or I am unable to verify. > I don't give my "Reviewed-by" because this review is very incomplete. > But unless anyone else opposes feel free to push it. > > Of course, we need a permission from Siddhesh (CC) > > Regards, > > Rafal > --=20 Mike FABIAN =E7=9D=A1=E7=9C=A0=E4=B8=8D=E8=B6=B3=E3=81=AF=E3=81=84=E3=81=84=E4=BB=95=E4= =BA=8B=E3=81=AE=E6=95=B5=E3=81=A0=E3=80=82