From: Andreas Schwab via Libc-alpha <libc-alpha@sourceware.org>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] <time.h>: Make strptime available by default
Date: Mon, 28 Nov 2022 14:55:18 +0100 [thread overview]
Message-ID: <mvmlenv89q1.fsf@suse.de> (raw)
In-Reply-To: <87lenvrzey.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Mon, 28 Nov 2022 14:17:41 +0100")
On Nov 28 2022, Florian Weimer via Libc-alpha wrote:
> This matches what FreeBSD does.
Does it? What I see is that the strptime declaration is conditional on
__XSI_VISIBLE, which is their equivalent of __USE_XOPEN, I think.
> diff --git a/time/time.h b/time/time.h
> index d18089116e..f507b44228 100644
> --- a/time/time.h
> +++ b/time/time.h
> @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize,
> const char *__restrict __format,
> const struct tm *__restrict __tp) __THROW;
>
> -#ifdef __USE_XOPEN
> +#if (defined __USE_XOPEN || defined __USE_MISC)
No need for parens.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2022-11-28 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 13:17 [PATCH] <time.h>: Make strptime available by default Florian Weimer via Libc-alpha
2022-11-28 13:55 ` Andreas Schwab via Libc-alpha [this message]
2022-11-28 14:52 ` Florian Weimer via Libc-alpha
2022-11-28 15:37 ` Andreas Schwab via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmlenv89q1.fsf@suse.de \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).