unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Andreas Schwab <schwab@suse.de>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] <time.h>: Make strptime available by default
Date: Mon, 28 Nov 2022 15:52:04 +0100	[thread overview]
Message-ID: <878rjvrv1n.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <mvmlenv89q1.fsf@suse.de> (Andreas Schwab's message of "Mon, 28 Nov 2022 14:55:18 +0100")

* Andreas Schwab:

> On Nov 28 2022, Florian Weimer via Libc-alpha wrote:
>
>> This matches what FreeBSD does.
>
> Does it?  What I see is that the strptime declaration is conditional on
> __XSI_VISIBLE, which is their equivalent of __USE_XOPEN, I think.

Clang without any special flags defines __XSI_VISBLE to 700 on FreeBSD
13.1 at least, which is why the declaration is visible by default.

I'm not sure why we don't default to __USE_XOPEN.  Maybe it has
something to do with our diverging definitions of strerror_r and
basename?

Thanks,
Florian


  reply	other threads:[~2022-11-28 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 13:17 [PATCH] <time.h>: Make strptime available by default Florian Weimer via Libc-alpha
2022-11-28 13:55 ` Andreas Schwab via Libc-alpha
2022-11-28 14:52   ` Florian Weimer via Libc-alpha [this message]
2022-11-28 15:37     ` Andreas Schwab via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rjvrv1n.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=fweimer@redhat.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).