From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4EAA71F4C1 for ; Mon, 28 Nov 2022 14:52:33 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="M1/nU/Z5"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 47015384EF77 for ; Mon, 28 Nov 2022 14:52:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47015384EF77 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669647152; bh=GBI5SwcoBmv59xIa66fwsDKYSKOavH5aglOI3gAGACU=; h=To:Cc:Subject:References:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=M1/nU/Z52w1+ofMM+YUMDrTr25zVH/gvBG6kZ6+4Pl0yipFb8E7JwtNNtkmt/3x6t /5YNQD1QcIIytur0VnioMwk/Mx/Wujky6zvJTJwB0Wzr7jr79wkFs0ZXx07jvtisup jzKxQJxb6MZxBN+iwy6lZIFReE9G9WsrbfkX7uIc= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B2FB43855173 for ; Mon, 28 Nov 2022 14:52:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2FB43855173 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-216-h5QwFGR5McmrVfXh0DiY2w-1; Mon, 28 Nov 2022 09:52:09 -0500 X-MC-Unique: h5QwFGR5McmrVfXh0DiY2w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3C651C04B66; Mon, 28 Nov 2022 14:52:08 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D93E40C6EC2; Mon, 28 Nov 2022 14:52:07 +0000 (UTC) To: Andreas Schwab Cc: Florian Weimer via Libc-alpha Subject: Re: [PATCH] : Make strptime available by default References: <87lenvrzey.fsf@oldenburg.str.redhat.com> Date: Mon, 28 Nov 2022 15:52:04 +0100 In-Reply-To: (Andreas Schwab's message of "Mon, 28 Nov 2022 14:55:18 +0100") Message-ID: <878rjvrv1n.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Andreas Schwab: > On Nov 28 2022, Florian Weimer via Libc-alpha wrote: > >> This matches what FreeBSD does. > > Does it? What I see is that the strptime declaration is conditional on > __XSI_VISIBLE, which is their equivalent of __USE_XOPEN, I think. Clang without any special flags defines __XSI_VISBLE to 700 on FreeBSD 13.1 at least, which is why the declaration is visible by default. I'm not sure why we don't default to __USE_XOPEN. Maybe it has something to do with our diverging definitions of strerror_r and basename? Thanks, Florian