From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EFEF21F4C1 for ; Mon, 28 Nov 2022 13:55:41 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="oW/MLuSd"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BC98B385B513 for ; Mon, 28 Nov 2022 13:55:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC98B385B513 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669643740; bh=98uJqTAkFFqqcO0tFIhhX0CXu+XbzSVBOsnJJhpZZCk=; h=To:Cc:Subject:References:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=oW/MLuSdEH5pcUeW3oUWrQNMGe6PtjiOBfO3XXX/pQd5SGKZYD7RWw+HfyoRlI7ng X+mCxp8IlRSP3VBqWxn7JCJNf1vsWiQZGVvzvcLZTOZ/73ZjXVvCYf+9Onx3+1zNLG kDEZkBbhG9XAfUAj2klm5ev1oaZwnVHY3f7C1nEo= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id E51843858020 for ; Mon, 28 Nov 2022 13:55:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E51843858020 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 09FE01F74A; Mon, 28 Nov 2022 13:55:20 +0000 (UTC) Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 02F912C141; Mon, 28 Nov 2022 13:55:19 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id 6B06144017F; Mon, 28 Nov 2022 14:55:19 +0100 (CET) To: Florian Weimer via Libc-alpha Cc: Florian Weimer Subject: Re: [PATCH] : Make strptime available by default References: <87lenvrzey.fsf@oldenburg.str.redhat.com> X-Yow: These PRESERVES should be FORCE-FED to PENTAGON OFFICIALS!! Date: Mon, 28 Nov 2022 14:55:18 +0100 In-Reply-To: <87lenvrzey.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Mon, 28 Nov 2022 14:17:41 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andreas Schwab via Libc-alpha Reply-To: Andreas Schwab Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Nov 28 2022, Florian Weimer via Libc-alpha wrote: > This matches what FreeBSD does. Does it? What I see is that the strptime declaration is conditional on __XSI_VISIBLE, which is their equivalent of __USE_XOPEN, I think. > diff --git a/time/time.h b/time/time.h > index d18089116e..f507b44228 100644 > --- a/time/time.h > +++ b/time/time.h > @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize, > const char *__restrict __format, > const struct tm *__restrict __tp) __THROW; > > -#ifdef __USE_XOPEN > +#if (defined __USE_XOPEN || defined __USE_MISC) No need for parens. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."