unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
To: cltang@codesourcery.com, Andreas Schwab <schwab@linux-m68k.org>
Cc: Catherine Moore <clm@codesourcery.com>,
	GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader
Date: Sun, 26 Jul 2020 20:40:53 -0400	[thread overview]
Message-ID: <c03ec8fb-b0dd-d022-300b-830c4dbce361@redhat.com> (raw)
In-Reply-To: <1427b370-7400-afd0-16e8-55c1072db20e@mentor.com>

On 7/22/20 2:10 PM, Chung-Lin Tang wrote:
> I only now notice that "permute" vs "permutate" is an issue :) I've corrected the
> spelling as you've suggested.
> 
> The v3 patch is attached, please see if this is now okay for committing.

I'm going to review this shortly, but it's too late in the release to add it to 2.32.

My plan, if you agree, is as follows:

(a) Review this promptly this week.
(b) Switch the sense of the default to just use the new DFS sort.
(c) Open 2.33 for development and commit the changes.
(d) Sync Fedora Rawhide and spend the next 5 months testing this in Rawhide.

There are still a few more changes we need to make in the test generation,
for example the tests don't use support/test-driver.c which means they could
hang the entire testsuite and they don't support timeouts because of this.

We should follow generating the test such that the executable uses test-drive.c
like all new tests should. This way we can catch tests that used to take 200s
and now take 1s (default timeout at 20s).

-- 
Cheers,
Carlos.


  reply	other threads:[~2020-07-27  0:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 13:24 [PATCH v2 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader Chung-Lin Tang
2020-05-19 14:21 ` Andreas Schwab
2020-05-19 14:33   ` Chung-Lin Tang
2020-05-19 14:50     ` Andreas Schwab
2020-05-20 14:38       ` [PATCH v2.1 " Chung-Lin Tang
2020-06-05 13:56         ` Carlos O'Donell via Libc-alpha
2020-06-18 21:30         ` Carlos O'Donell via Libc-alpha
2020-07-22 18:10           ` [PATCH v3 " Chung-Lin Tang
2020-07-27  0:40             ` Carlos O'Donell via Libc-alpha [this message]
2020-07-27 10:00               ` Chung-Lin Tang
2020-07-27 10:12                 ` Florian Weimer via Libc-alpha
2020-08-08  4:42               ` Carlos O'Donell via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c03ec8fb-b0dd-d022-300b-830c4dbce361@redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=carlos@redhat.com \
    --cc=clm@codesourcery.com \
    --cc=cltang@codesourcery.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).