Re: [PATCH v3 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader

[Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>]

On 7/26/20 8:40 PM, Carlos O'Donell wrote:
> On 7/22/20 2:10 PM, Chung-Lin Tang wrote:
>> I only now notice that "permute" vs "permutate" is an issue :) I've corrected the
>> spelling as you've suggested.
>>
>> The v3 patch is attached, please see if this is now okay for committing.
> 
> I'm going to review this shortly, but it's too late in the release to add it to 2.32.
> 
> My plan, if you agree, is as follows:
> 
> (a) Review this promptly this week.
> (b) Switch the sense of the default to just use the new DFS sort.
> (c) Open 2.33 for development and commit the changes.
> (d) Sync Fedora Rawhide and spend the next 5 months testing this in Rawhide.
> 
> There are still a few more changes we need to make in the test generation,
> for example the tests don't use support/test-driver.c which means they could
> hang the entire testsuite and they don't support timeouts because of this.
> 
> We should follow generating the test such that the executable uses test-drive.c
> like all new tests should. This way we can catch tests that used to take 200s
> and now take 1s (default timeout at 20s).
 
This is still on my plate to review along with DJ's nsswitch.conf changes.

-- 
Cheers,
Carlos.