unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Chung-Lin Tang <cltang@codesourcery.com>
Cc: Catherine Moore <clm@codesourcery.com>,
	GNU C Library <libc-alpha@sourceware.org>,
	Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH v3 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader
Date: Mon, 27 Jul 2020 12:12:33 +0200	[thread overview]
Message-ID: <87sgdd1d2m.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <47d5d0a3-4e55-d915-8ced-6ad0c68d6aaf@codesourcery.com> (Chung-Lin Tang's message of "Mon, 27 Jul 2020 18:00:21 +0800")

* Chung-Lin Tang:

> I understand the need to support timeouts, but actually, because of
> the nature of the ld.so sorting tests, where a lot of the action
> happens before/after main(), making the testcase executables use
> support/test-driver.c isn't really that meaningful. In terms of the
> relations, you would need to wrap the entire ld.so into a testcase for
> that to work.

Agreed.  I think having a test without that protection should be fine,
if it indeed runs in a few seconds now.

> Do we already have some support program that embeds
> support/test-driver.c (like a testcase) and allows forking of a
> generic program + command-line? That should allow running the entire
> ld.so with a timeout I suppose. Another method would be to do
> something in the generated shell script wrapper to implement a
> timeout.

Historically, we have used shell tests for that.

Thanks,
Florian


  reply	other threads:[~2020-07-27 10:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 13:24 [PATCH v2 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader Chung-Lin Tang
2020-05-19 14:21 ` Andreas Schwab
2020-05-19 14:33   ` Chung-Lin Tang
2020-05-19 14:50     ` Andreas Schwab
2020-05-20 14:38       ` [PATCH v2.1 " Chung-Lin Tang
2020-06-05 13:56         ` Carlos O'Donell via Libc-alpha
2020-06-18 21:30         ` Carlos O'Donell via Libc-alpha
2020-07-22 18:10           ` [PATCH v3 " Chung-Lin Tang
2020-07-27  0:40             ` Carlos O'Donell via Libc-alpha
2020-07-27 10:00               ` Chung-Lin Tang
2020-07-27 10:12                 ` Florian Weimer via Libc-alpha [this message]
2020-08-08  4:42               ` Carlos O'Donell via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgdd1d2m.fsf@oldenburg2.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=clm@codesourcery.com \
    --cc=cltang@codesourcery.com \
    --cc=fweimer@redhat.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).