From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: Removing internal symbols (Was: htl: Rename _pthread_mutex_init/destroy to __pthread_mutex_init/destroy)
Date: Tue, 28 Jan 2020 09:56:38 -0300 [thread overview]
Message-ID: <b2eaca23-1157-fd1c-180c-6c2ff4d15add@linaro.org> (raw)
In-Reply-To: <20200127215535.b5azfecvkmeuf7at@function>
On 27/01/2020 18:55, Samuel Thibault wrote:
> Hello,
>
> Expanding the subject a bit to catch more opinions on this:
>
> Samuel Thibault, le mar. 21 janv. 2020 22:28:50 +0100, a ecrit:
>> Adhemerval Zanella, le ven. 17 janv. 2020 17:40:09 -0300, a ecrit:
>>>> diff --git a/sysdeps/mach/hurd/i386/libpthread.abilist b/sysdeps/mach/hurd/i386/libpthread.abilist
>>>> index 0ede90859c..cda8755960 100644
>>>> --- a/sysdeps/mach/hurd/i386/libpthread.abilist
>>>> +++ b/sysdeps/mach/hurd/i386/libpthread.abilist
>>>> @@ -14,8 +14,6 @@ GLIBC_2.12 _cthread_init_routine D 0x4
>>>> GLIBC_2.12 _cthreads_flockfile F
>>>> GLIBC_2.12 _cthreads_ftrylockfile F
>>>> GLIBC_2.12 _cthreads_funlockfile F
>>>> -GLIBC_2.12 _pthread_mutex_destroy F
>>>> -GLIBC_2.12 _pthread_mutex_init F
>>>> GLIBC_2.12 _pthread_mutex_lock F
>>>> GLIBC_2.12 _pthread_mutex_trylock F
>>>> GLIBC_2.12 _pthread_mutex_unlock F
>>>
>>> I understand this change is follow Linux internal implementation
>>> and make mtx_init.c generic, but I don't think changing hurd
>>> libpthread exported symbols is the correct solution.
>>>
>>> Since the symbol won't be used anymore I think we can move to
>>> a compat symbol, something like:
>>>
>>> +strong_alias (__pthread_mutex_init, pthread_mutex_init);
>>> +hidden_def (__pthread_mutex_init)
>>> +#if SHLIB_COMPAT (libpthread, GLIBC_2_12, GLIBC_2_31)
>>> +compat_symbol (libpthread, __pthread_mutex_init, _pthread_mutex_init, GLIBC_2_12);
>>> +#endif
>>
>> But do we need to keep the compat symbols at all?
>>
>> _pthread_mutex_lock has never been exposed in a .h file, it should have
>> gotten version GLIBC_PRIVATE actually since it's only used between
>> libc.so and libpthread.so.
I think it might be fine in this case, assuming there is no external linkage
possible with header redirection. It is still a ABI break, but if an
application is using such symbol it is abusing the API.
next prev parent reply other threads:[~2020-01-28 12:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 18:52 [PATCH 00/10] Port C11 threads to GNU/Hurd Samuel Thibault
2020-01-14 18:52 ` [hurd,commited] htl: Add internal version of __pthread_mutex_timedlock Samuel Thibault
2020-01-14 18:52 ` [PATCH 01/10] htl: Rename _pthread_mutex_init/destroy to __pthread_mutex_init/destroy Samuel Thibault
2020-01-17 20:40 ` Adhemerval Zanella
2020-01-21 21:28 ` Samuel Thibault
2020-01-27 21:55 ` Removing internal symbols (Was: htl: Rename _pthread_mutex_init/destroy to __pthread_mutex_init/destroy) Samuel Thibault
2020-01-28 12:56 ` Adhemerval Zanella [this message]
2020-01-28 13:58 ` Removing internal symbols Florian Weimer
2020-01-14 18:52 ` [PATCH 02/10] htl: Add missing internal functions declarations Samuel Thibault
2020-01-20 17:11 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 03/10] htl: Add support for C11 threads behavior Samuel Thibault
2020-01-20 17:15 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 04/10] htl: Make __PTHREAD_ONCE_INIT more flexible Samuel Thibault
2020-01-20 18:01 ` Adhemerval Zanella
2020-01-20 18:29 ` Samuel Thibault
2020-01-14 18:52 ` [PATCH 05/10] nptl: Move nptl-specific types to separate header Samuel Thibault
2020-01-20 18:31 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 06/10] C11 threads: do not require PTHREAD_DESTRUCTOR_ITERATIONS Samuel Thibault
2020-01-20 18:40 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 07/10] C11 threads: Fix thrd_t / pthread_t compatibility assertion Samuel Thibault
2020-01-20 18:52 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 08/10] C11 threads: make thrd_join more portable Samuel Thibault
2020-01-20 18:53 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 09/10] htl: Add C11 threads types definitions Samuel Thibault
2020-01-20 19:08 ` Adhemerval Zanella
2020-01-20 20:58 ` Samuel Thibault
2020-01-21 11:35 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 10/10] C11 threads: Move implementation to sysdeps/pthread Samuel Thibault
2020-01-21 12:39 ` Adhemerval Zanella
2020-01-21 22:01 ` Samuel Thibault
2020-01-22 12:36 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2eaca23-1157-fd1c-180c-6c2ff4d15add@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).