From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B8D451F466 for ; Tue, 28 Jan 2020 12:56:47 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=V/96YTMVdhaj68/2 0WVlGt4pCVHbwArFtXJG0txgWWoTVsjRu8hhh8zwPwqNpozhgVyJ6+vUchHmTeLd rMwmo14CjkrWibr4gbiSAVhzwj0AeyuYBGzcM+ShHLyqPjRcTIZNovjIypN+ZHDq kHAwpwvS5oexGJBFFGKOYZvrjfM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=Tvs7SUdEvnrEvXOmfEsnpa TStx4=; b=MNstVeOSS3mPoZcZkp8CC7ldPhTQ1v9twfeiR4XBcqKbyz/81ceSvb jovgfN/zXPJeEivQb4U0VIKc412kQ1nHWpQyqu3QbciSFlkTu7nS+3o2vbGxW6Tg zlweYUafwQ91hiUV8QNDjw4gMLh31XkthNeexMlQQ1IjcvvoEhnIA= Received: (qmail 112527 invoked by alias); 28 Jan 2020 12:56:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 112518 invoked by uid 89); 28 Jan 2020 12:56:44 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f194.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fnmW45iMlru7Aq5grnViUPwjawzd6l3cVFDmg8DnrHQ=; b=Hz+6vZYDk59ElUffAkPHsppkq5BattsJ6+LWom5LTb2KG8nyNBs9u2y/H7wvycb/cL 4lyM9fVGFrMB4kYg4F/7vSQY85jOda91Ig98eQSBaoibZIKbVrhRM9TvLYFYPx8NRXo2 Wc2BDSSYBrTCri649gyUpY4ZJaWUsPUyWW+dv25Yg8h26UkSsEliGngNg1dPhnzUidSn PnmdRaopajbL9ORrns48PA1VK+zd4F2PMkNg8nWRpiyNcDbjzH7hnikEGupFrnW0YPSY hyOIbp0KCzAaH0af6UnkKNIjrbZ3hkSie9JGyTYaasTL0CC2chQ6cgExHpj68sNbQ5AR C7YQ== To: libc-alpha@sourceware.org References: <20200114185255.25813-1-samuel.thibault@ens-lyon.org> <20200114185255.25813-3-samuel.thibault@ens-lyon.org> <20200121212850.ufsmja7evi3bhwjx@function> <20200127215535.b5azfecvkmeuf7at@function> From: Adhemerval Zanella Subject: Re: Removing internal symbols (Was: htl: Rename _pthread_mutex_init/destroy to __pthread_mutex_init/destroy) Message-ID: Date: Tue, 28 Jan 2020 09:56:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200127215535.b5azfecvkmeuf7at@function> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 27/01/2020 18:55, Samuel Thibault wrote: > Hello, > > Expanding the subject a bit to catch more opinions on this: > > Samuel Thibault, le mar. 21 janv. 2020 22:28:50 +0100, a ecrit: >> Adhemerval Zanella, le ven. 17 janv. 2020 17:40:09 -0300, a ecrit: >>>> diff --git a/sysdeps/mach/hurd/i386/libpthread.abilist b/sysdeps/mach/hurd/i386/libpthread.abilist >>>> index 0ede90859c..cda8755960 100644 >>>> --- a/sysdeps/mach/hurd/i386/libpthread.abilist >>>> +++ b/sysdeps/mach/hurd/i386/libpthread.abilist >>>> @@ -14,8 +14,6 @@ GLIBC_2.12 _cthread_init_routine D 0x4 >>>> GLIBC_2.12 _cthreads_flockfile F >>>> GLIBC_2.12 _cthreads_ftrylockfile F >>>> GLIBC_2.12 _cthreads_funlockfile F >>>> -GLIBC_2.12 _pthread_mutex_destroy F >>>> -GLIBC_2.12 _pthread_mutex_init F >>>> GLIBC_2.12 _pthread_mutex_lock F >>>> GLIBC_2.12 _pthread_mutex_trylock F >>>> GLIBC_2.12 _pthread_mutex_unlock F >>> >>> I understand this change is follow Linux internal implementation >>> and make mtx_init.c generic, but I don't think changing hurd >>> libpthread exported symbols is the correct solution. >>> >>> Since the symbol won't be used anymore I think we can move to >>> a compat symbol, something like: >>> >>> +strong_alias (__pthread_mutex_init, pthread_mutex_init); >>> +hidden_def (__pthread_mutex_init) >>> +#if SHLIB_COMPAT (libpthread, GLIBC_2_12, GLIBC_2_31) >>> +compat_symbol (libpthread, __pthread_mutex_init, _pthread_mutex_init, GLIBC_2_12); >>> +#endif >> >> But do we need to keep the compat symbols at all? >> >> _pthread_mutex_lock has never been exposed in a .h file, it should have >> gotten version GLIBC_PRIVATE actually since it's only used between >> libc.so and libpthread.so. I think it might be fine in this case, assuming there is no external linkage possible with header redirection. It is still a ABI break, but if an application is using such symbol it is abusing the API.